Use clearwater-rb's fork of virtual-dom #66
Merged
+2,953
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 28, 2016 22:18
jgaskins
added a commit
that referenced
this pull request
Mar 27, 2017
A JS string created with:
new String("hello")
... does not match virtual-dom's type checks. Until we merge in #66,
this will have to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've begun maintaining our own fork of the
virtual-domlibrary (note: we're using theclearwater-importbranch).So far, it contains a performance boost, a couple patches to make element properties that depend on their children to work more smoothly, and more Clearwater-friendly error messages.
This does mean that this fork is intended to be used with Clearwater and we probably won't go out of our way to make it usable without it since people with that use case can use the canonical
virtual-domlibrary.This is related to #48, but does not include the hydration feature. Instead, that PR should be built on top of this one.