Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

Commit

Permalink
Merge branch 'master' into greenkeeper/tap-10.7.0
Browse files Browse the repository at this point in the history
  • Loading branch information
clebert committed Jun 27, 2017
2 parents 81271cc + 5a8e02d commit 46c5a00
Show file tree
Hide file tree
Showing 9 changed files with 24 additions and 28 deletions.
10 changes: 5 additions & 5 deletions package.json
Expand Up @@ -78,7 +78,7 @@
},
"devDependencies": {
"@types/jest": "20.0.2",
"@types/node": "8.0.2",
"@types/node": "8.0.4",
"commitizen": "2.9.6",
"conventional-changelog-lint": "1.1.9",
"coveralls": "2.13.1",
Expand All @@ -88,11 +88,11 @@
"gitbook-cli": "2.3.0",
"jest": "20.0.4",
"markdownlint": "0.5.0",
"prettier": "1.4.4",
"standard-version": "4.0.0",
"ts-config": "9.3.0",
"prettier": "1.5.0",
"standard-version": "4.2.0",
"ts-config": "9.4.0",
"ts-jest": "20.0.6",
"tslint": "5.4.3",
"typescript": "2.3.4"
"typescript": "2.4.1"
}
}
4 changes: 2 additions & 2 deletions scripts/lib/cybernaut-xvfb.sh
Expand Up @@ -2,13 +2,13 @@

set -e

if [ -z "$1" ];
if [ -z "$1" ]
then
echo 'Missing argument: screen size'
exit 1
fi

if [ -z "$2" ];
if [ -z "$2" ]
then
echo 'Missing argument: reporter'
exit 1
Expand Down
8 changes: 0 additions & 8 deletions scripts/lib/shellcheck.sh

This file was deleted.

6 changes: 3 additions & 3 deletions scripts/make/targets/dist.sh
Expand Up @@ -62,23 +62,23 @@ echo '# Cleaning the Docker artifacts #########################################'

EXITED_CONTAINERS=$(docker ps -a -q -f status=exited)

if [ -n "$EXITED_CONTAINERS" ];
if [ -n "$EXITED_CONTAINERS" ]
then
# shellcheck disable=SC2086
docker rm -v $EXITED_CONTAINERS
fi

DANGLING_IMAGES=$(docker images -f "dangling=true" -q)

if [ -n "$DANGLING_IMAGES" ];
if [ -n "$DANGLING_IMAGES" ]
then
# shellcheck disable=SC2086
docker rmi $DANGLING_IMAGES
fi

DANGLING_VOLUMES=$(docker volume ls -qf dangling=true)

if [ -n "$DANGLING_VOLUMES" ];
if [ -n "$DANGLING_VOLUMES" ]
then
# shellcheck disable=SC2086
docker volume rm $DANGLING_VOLUMES
Expand Down
4 changes: 2 additions & 2 deletions scripts/make/targets/e2e-tests.sh
Expand Up @@ -36,7 +36,7 @@ docker run -it --rm \
-v /dev/shm:/dev/shm \
clebert/cybernaut-chrome | tee e2e-tests/dist/chrome.log

if [ "${PIPESTATUS[0]}" != 0 ];
if [ "${PIPESTATUS[0]}" != 0 ]
then
exit "${PIPESTATUS[0]}"
fi
Expand All @@ -55,7 +55,7 @@ docker run -it --rm \
-v "$(pwd)"/e2e-tests/static:/opt/static \
clebert/cybernaut-firefox | tee e2e-tests/dist/firefox.log

if [ "${PIPESTATUS[0]}" != 0 ];
if [ "${PIPESTATUS[0]}" != 0 ]
then
exit "${PIPESTATUS[0]}"
fi
Expand Down
2 changes: 1 addition & 1 deletion scripts/make/targets/examples.sh
Expand Up @@ -35,7 +35,7 @@ docker run -it --rm \
-v /dev/shm:/dev/shm \
clebert/cybernaut-chrome | tee examples/dist/chrome.log

if [ "${PIPESTATUS[0]}" != 0 ];
if [ "${PIPESTATUS[0]}" != 0 ]
then
exit "${PIPESTATUS[0]}"
fi
8 changes: 6 additions & 2 deletions scripts/make/targets/scripts.sh
Expand Up @@ -29,8 +29,12 @@ echo '# Checking the formatting of the TS scripts #############################'

echo '# Checking the shell scripts ############################################'

SHELL_SCRIPTS=$(find scripts -type f -name '*.sh')

# shellcheck disable=SC2086

docker run -it --rm \
-v "$(pwd)"/scripts:/scripts \
--entrypoint /bin/sh \
-w / \
koalaman/shellcheck \
/scripts/lib/shellcheck.sh
$SHELL_SCRIPTS
8 changes: 4 additions & 4 deletions scripts/npm/push.sh
Expand Up @@ -2,13 +2,13 @@

set -e

if [ -z "$DOCKER_USERNAME" ];
if [ -z "$DOCKER_USERNAME" ]
then
echo 'Missing environment variable: DOCKER_USERNAME'
exit 1
fi

if [ -z "$DOCKER_PASSWORD" ];
if [ -z "$DOCKER_PASSWORD" ]
then
echo 'Missing environment variable: DOCKER_PASSWORD'
exit 1
Expand All @@ -18,7 +18,7 @@ GIT_BRANCH=$(git rev-parse --abbrev-ref HEAD)
GIT_TAG=$("$(npm bin)"/git-latest-semver-tag)
VERSION="${GIT_TAG:1}"

if [ "$GIT_BRANCH" != master ];
if [ "$GIT_BRANCH" != master ]
then
echo 'Please checkout the master branch'
exit 1
Expand All @@ -31,7 +31,7 @@ make clean && make

echo '# Checking the Git status ###############################################'

if [ -n "$(git status --porcelain)" ];
if [ -n "$(git status --porcelain)" ]
then
echo 'Dirty Git working tree'
exit 1
Expand Down
2 changes: 1 addition & 1 deletion src/selenium/browser.ts
Expand Up @@ -84,7 +84,7 @@ export function scriptResult<T>(
): SeleniumAccessor<T> {
return {
description: `The result of the ${scriptName} script`,
get: async driver => driver.executeAsyncScript(script)
get: async driver => driver.executeAsyncScript<T>(script)
};
}

Expand Down

0 comments on commit 46c5a00

Please sign in to comment.