feat(todomvc): move pageobject-puppeteer to dev dependencies (#226)

clebert · Apr 24, 2018 · babbd15 · babbd15
1 parent 9cb36fb
commit babbd15
Show file tree

Hide file tree

Showing 14 changed files with 42 additions and 131 deletions.
diff --git a/@pageobject/todomvc/package.json b/@pageobject/todomvc/package.json
@@ -22,7 +22,9 @@
   },
   "dependencies": {
     "@pageobject/base": "^11.1.1",
-    "@pageobject/puppeteer": "^11.1.1",
     "@pageobject/web": "^11.1.1"
+  },
+  "devDependencies": {
+    "@pageobject/puppeteer": "^11.1.1"
   }
 }
diff --git a/@pageobject/todomvc/src/TodoMVC.ts b/@pageobject/todomvc/src/TodoMVC.ts
@@ -1,36 +1,8 @@
-import {Test, TestCallback} from '@pageobject/base';
-import {PuppeteerAdapter} from '@pageobject/puppeteer';
 import {WebComponent} from '@pageobject/web';
 import {NewTodoInput} from './NewTodoInput';
 import {TodoList} from './TodoList';
 
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 60 * 1000;
-
-const args =
-  process.env.CI === 'true'
-    ? ['--disable-dev-shm-usage', '--disable-setuid-sandbox', '--no-sandbox']
-    : [];
-
 export class TodoMVC extends WebComponent {
-  public static jest(name: string, callback: TestCallback<TodoMVC>): void {
-    test(name, async () => {
-      const adapter = await PuppeteerAdapter.create(
-        {args},
-        {waitUntil: 'domcontentloaded'}
-      );
-
-      try {
-        await Test.run(new TodoMVC(adapter), 10, callback);
-      } catch (e) {
-        await adapter.page.screenshot({path: 'error-screenshot.png'});
-
-        throw e;
-      } finally {
-        await adapter.quit();
-      }
-    });
-  }
-
   public readonly selector: string = '.todoapp';
 
   public readonly newTodoInput = new NewTodoInput(this.adapter, this);

diff --git a/@pageobject/todomvc/src/tests/completing-a-todo.test.ts b/@pageobject/todomvc/src/tests/completing-a-todo.test.ts
@@ -1,9 +1,9 @@
 import {Predicate} from '@pageobject/base';
-import {TodoMVC} from '..';
+import {jestTest} from './jestTest';
 
 const {is} = Predicate;
 
-TodoMVC.jest('Completing a todo', (test, app) => {
+jestTest('Completing a todo', (test, app) => {
   test.perform(app.page.goto('http://todomvc.com/examples/react/#/'), 30);
 
   test

diff --git a/@pageobject/todomvc/src/tests/creating-todos.test.ts b/@pageobject/todomvc/src/tests/creating-todos.test.ts
@@ -1,9 +1,9 @@
 import {Predicate} from '@pageobject/base';
-import {TodoMVC} from '..';
+import {jestTest} from './jestTest';
 
 const {is} = Predicate;
 
-TodoMVC.jest('Creating todos', (test, app) => {
+jestTest('Creating todos', (test, app) => {
   test.perform(app.page.goto('http://todomvc.com/examples/react/#/'), 30);
 
   test

diff --git a/@pageobject/todomvc/src/tests/jestTest.ts b/@pageobject/todomvc/src/tests/jestTest.ts
@@ -0,0 +1,29 @@
+import {Test, TestCallback} from '@pageobject/base';
+import {PuppeteerAdapter} from '@pageobject/puppeteer';
+import {TodoMVC} from '..';
+
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 60 * 1000;
+
+const args =
+  process.env.CI === 'true'
+    ? ['--disable-dev-shm-usage', '--disable-setuid-sandbox', '--no-sandbox']
+    : [];
+
+export function jestTest(name: string, callback: TestCallback<TodoMVC>): void {
+  test(name, async () => {
+    const adapter = await PuppeteerAdapter.create(
+      {args},
+      {waitUntil: 'domcontentloaded'}
+    );
+
+    try {
+      await Test.run(new TodoMVC(adapter), 10, callback);
+    } catch (e) {
+      await adapter.page.screenshot({path: 'error-screenshot.png'});
+
+      throw e;
+    } finally {
+      await adapter.quit();
+    }
+  });
+}
diff --git a/docs/api/todomvc/assets/js/search.js b/docs/api/todomvc/assets/js/search.js
diff --git a/docs/api/todomvc/classes/label.html b/docs/api/todomvc/classes/label.html
@@ -996,9 +996,6 @@
 		<li class=" tsd-kind-class">
 			<a href="toggle.html" class="tsd-kind-icon">Toggle</a>
 		</li>
-		<li class=" tsd-kind-variable tsd-is-not-exported">
-			<a href="../globals.html#args" class="tsd-kind-icon">args</a>
-		</li>
 	</ul>
 </nav>
 <div class="container container-main">

diff --git a/docs/api/todomvc/classes/newtodoinput.html b/docs/api/todomvc/classes/newtodoinput.html
@@ -996,9 +996,6 @@
 		<li class=" tsd-kind-class">
 			<a href="toggle.html" class="tsd-kind-icon">Toggle</a>
 		</li>
-		<li class=" tsd-kind-variable tsd-is-not-exported">
-			<a href="../globals.html#args" class="tsd-kind-icon">args</a>
-		</li>
 	</ul>
 </nav>
 <div class="container container-main">

diff --git a/docs/api/todomvc/classes/todo.html b/docs/api/todomvc/classes/todo.html
@@ -1002,9 +1002,6 @@
 		<li class=" tsd-kind-class">
 			<a href="toggle.html" class="tsd-kind-icon">Toggle</a>
 		</li>
-		<li class=" tsd-kind-variable tsd-is-not-exported">
-			<a href="../globals.html#args" class="tsd-kind-icon">args</a>
-		</li>
 	</ul>
 </nav>
 <div class="container container-main">

diff --git a/docs/api/todomvc/classes/todolist.html b/docs/api/todomvc/classes/todolist.html
@@ -999,9 +999,6 @@
 		<li class=" tsd-kind-class">
 			<a href="toggle.html" class="tsd-kind-icon">Toggle</a>
 		</li>
-		<li class=" tsd-kind-variable tsd-is-not-exported">
-			<a href="../globals.html#args" class="tsd-kind-icon">args</a>
-		</li>
 	</ul>
 </nav>
 <div class="container container-main">

diff --git a/docs/api/todomvc/classes/todomvc.html b/docs/api/todomvc/classes/todomvc.html
@@ -997,17 +997,11 @@
 				<li class=" tsd-kind-method tsd-parent-kind-class tsd-has-type-parameter tsd-is-inherited">
 					<a href="todomvc.html#where" class="tsd-kind-icon">where</a>
 				</li>
-				<li class=" tsd-kind-method tsd-parent-kind-class tsd-is-static">
-					<a href="todomvc.html#jest" class="tsd-kind-icon">jest</a>
-				</li>
 			</ul>
 		</li>
 		<li class=" tsd-kind-class">
 			<a href="toggle.html" class="tsd-kind-icon">Toggle</a>
 		</li>
-		<li class=" tsd-kind-variable tsd-is-not-exported">
-			<a href="../globals.html#args" class="tsd-kind-icon">args</a>
-		</li>
 	</ul>
 </nav>
 <div class="container container-main">
@@ -1047,7 +1041,7 @@ <h3>Properties</h3>
 							<li class="tsd-kind-property tsd-parent-kind-class"><a href="todomvc.html#todolist" class="tsd-kind-icon">todo<wbr>List</a></li>
 						</ul>
 					</section>
-					<section class="tsd-index-section ">
+					<section class="tsd-index-section tsd-is-inherited">
 						<h3>Methods</h3>
 						<ul class="tsd-index-list">
 							<li class="tsd-kind-method tsd-parent-kind-class tsd-is-inherited"><a href="todomvc.html#click" class="tsd-kind-icon">click</a></li>
@@ -1067,7 +1061,6 @@ <h3>Methods</h3>
 							<li class="tsd-kind-method tsd-parent-kind-class tsd-is-inherited"><a href="todomvc.html#scrollintoview" class="tsd-kind-icon">scroll<wbr>Into<wbr>View</a></li>
 							<li class="tsd-kind-method tsd-parent-kind-class tsd-is-inherited"><a href="todomvc.html#tostring" class="tsd-kind-icon">to<wbr>String</a></li>
 							<li class="tsd-kind-method tsd-parent-kind-class tsd-has-type-parameter tsd-is-inherited"><a href="todomvc.html#where" class="tsd-kind-icon">where</a></li>
-							<li class="tsd-kind-method tsd-parent-kind-class tsd-is-static"><a href="todomvc.html#jest" class="tsd-kind-icon">jest</a></li>
 						</ul>
 					</section>
 				</div>
@@ -1145,7 +1138,7 @@ <h3>new<wbr>Todo<wbr>Input</h3>
 				<div class="tsd-signature tsd-kind-icon">new<wbr>Todo<wbr>Input<span class="tsd-signature-symbol">:</span> <a href="newtodoinput.html" class="tsd-signature-type">NewTodoInput</a><span class="tsd-signature-symbol"> =&nbsp;new NewTodoInput(this.adapter, this)</span></div>
 				<aside class="tsd-sources">
 					<ul>
-						<li>Defined in <a href="https://github.com/clebert/pageobject/blob/master/@pageobject/todomvc/src/TodoMVC.ts#L36">TodoMVC.ts:36</a></li>
+						<li>Defined in <a href="https://github.com/clebert/pageobject/blob/master/@pageobject/todomvc/src/TodoMVC.ts#L8">TodoMVC.ts:8</a></li>
 					</ul>
 				</aside>
 			</section>
@@ -1167,7 +1160,7 @@ <h3>selector</h3>
 				<aside class="tsd-sources">
 					<p>Overrides Component.selector</p>
 					<ul>
-						<li>Defined in <a href="https://github.com/clebert/pageobject/blob/master/@pageobject/todomvc/src/TodoMVC.ts#L34">TodoMVC.ts:34</a></li>
+						<li>Defined in <a href="https://github.com/clebert/pageobject/blob/master/@pageobject/todomvc/src/TodoMVC.ts#L6">TodoMVC.ts:6</a></li>
 					</ul>
 				</aside>
 			</section>
@@ -1177,12 +1170,12 @@ <h3>todo<wbr>List</h3>
 				<div class="tsd-signature tsd-kind-icon">todo<wbr>List<span class="tsd-signature-symbol">:</span> <a href="todolist.html" class="tsd-signature-type">TodoList</a><span class="tsd-signature-symbol"> =&nbsp;new TodoList(this.adapter, this)</span></div>
 				<aside class="tsd-sources">
 					<ul>
-						<li>Defined in <a href="https://github.com/clebert/pageobject/blob/master/@pageobject/todomvc/src/TodoMVC.ts#L37">TodoMVC.ts:37</a></li>
+						<li>Defined in <a href="https://github.com/clebert/pageobject/blob/master/@pageobject/todomvc/src/TodoMVC.ts#L9">TodoMVC.ts:9</a></li>
 					</ul>
 				</aside>
 			</section>
 		</section>
-		<section class="tsd-panel-group tsd-member-group ">
+		<section class="tsd-panel-group tsd-member-group tsd-is-inherited">
 			<h2>Methods</h2>
 			<section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class tsd-is-inherited">
 				<a name="click" class="tsd-anchor"></a>
@@ -1553,32 +1546,6 @@ <h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">this</spa
 					</li>
 				</ul>
 			</section>
-			<section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class tsd-is-static">
-				<a name="jest" class="tsd-anchor"></a>
-				<h3><span class="tsd-flag ts-flagStatic">Static</span> jest</h3>
-				<ul class="tsd-signatures tsd-kind-method tsd-parent-kind-class tsd-is-static">
-					<li class="tsd-signature tsd-kind-icon">jest<span class="tsd-signature-symbol">(</span>name<span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">string</span>, callback<span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">TestCallback</span><span class="tsd-signature-symbol">&lt;</span><a href="todomvc.html" class="tsd-signature-type">TodoMVC</a><span class="tsd-signature-symbol">&gt;</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">void</span></li>
-				</ul>
-				<ul class="tsd-descriptions">
-					<li class="tsd-description">
-						<aside class="tsd-sources">
-							<ul>
-								<li>Defined in <a href="https://github.com/clebert/pageobject/blob/master/@pageobject/todomvc/src/TodoMVC.ts#L15">TodoMVC.ts:15</a></li>
-							</ul>
-						</aside>
-						<h4 class="tsd-parameters-title">Parameters</h4>
-						<ul class="tsd-parameters">
-							<li>
-								<h5>name: <span class="tsd-signature-type">string</span></h5>
-							</li>
-							<li>
-								<h5>callback: <span class="tsd-signature-type">TestCallback</span><span class="tsd-signature-symbol">&lt;</span><a href="todomvc.html" class="tsd-signature-type">TodoMVC</a><span class="tsd-signature-symbol">&gt;</span></h5>
-							</li>
-						</ul>
-						<h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">void</span></h4>
-					</li>
-				</ul>
-			</section>
 		</section>
 		<footer>
 			<div class="container">

diff --git a/docs/api/todomvc/classes/toggle.html b/docs/api/todomvc/classes/toggle.html
@@ -999,9 +999,6 @@
 				</li>
 			</ul>
 		</li>
-		<li class=" tsd-kind-variable tsd-is-not-exported">
-			<a href="../globals.html#args" class="tsd-kind-icon">args</a>
-		</li>
 	</ul>
 </nav>
 <div class="container container-main">

diff --git a/docs/api/todomvc/globals.html b/docs/api/todomvc/globals.html
@@ -925,9 +925,6 @@
 		<li class=" tsd-kind-class">
 			<a href="classes/toggle.html" class="tsd-kind-icon">Toggle</a>
 		</li>
-		<li class=" tsd-kind-variable tsd-is-not-exported">
-			<a href="globals.html#args" class="tsd-kind-icon">args</a>
-		</li>
 	</ul>
 </nav>
 <div class="container container-main">
@@ -1001,28 +998,9 @@ <h3>Classes</h3>
 							<li class="tsd-kind-class"><a href="classes/toggle.html" class="tsd-kind-icon">Toggle</a></li>
 						</ul>
 					</section>
-					<section class="tsd-index-section tsd-is-not-exported">
-						<h3>Variables</h3>
-						<ul class="tsd-index-list">
-							<li class="tsd-kind-variable tsd-is-not-exported"><a href="globals.html#args" class="tsd-kind-icon">args</a></li>
-						</ul>
-					</section>
 				</div>
 			</section>
 		</section>
-		<section class="tsd-panel-group tsd-member-group tsd-is-not-exported">
-			<h2>Variables</h2>
-			<section class="tsd-panel tsd-member tsd-kind-variable tsd-is-not-exported">
-				<a name="args" class="tsd-anchor"></a>
-				<h3><span class="tsd-flag ts-flagConst">Const</span> args</h3>
-				<div class="tsd-signature tsd-kind-icon">args<span class="tsd-signature-symbol">:</span> <span class="tsd-signature-type">string</span><span class="tsd-signature-symbol">[]</span><span class="tsd-signature-symbol"> =&nbsp;process.env.CI &#x3D;&#x3D;&#x3D; &#x27;true&#x27;? [&#x27;--disable-dev-shm-usage&#x27;, &#x27;--disable-setuid-sandbox&#x27;, &#x27;--no-sandbox&#x27;]: []</span></div>
-				<aside class="tsd-sources">
-					<ul>
-						<li>Defined in <a href="https://github.com/clebert/pageobject/blob/master/@pageobject/todomvc/src/TodoMVC.ts#L9">TodoMVC.ts:9</a></li>
-					</ul>
-				</aside>
-			</section>
-		</section>
 		<footer>
 			<div class="container">
 				<h2>Legend</h2>

diff --git a/docs/api/todomvc/index.html b/docs/api/todomvc/index.html
@@ -925,9 +925,6 @@
 		<li class=" tsd-kind-class">
 			<a href="classes/toggle.html" class="tsd-kind-icon">Toggle</a>
 		</li>
-		<li class=" tsd-kind-variable tsd-is-not-exported">
-			<a href="globals.html#args" class="tsd-kind-icon">args</a>
-		</li>
 	</ul>
 </nav>
 <div class="container container-main">
@@ -1002,28 +999,9 @@ <h3>Classes</h3>
 							<li class="tsd-kind-class"><a href="classes/toggle.html" class="tsd-kind-icon">Toggle</a></li>
 						</ul>
 					</section>
-					<section class="tsd-index-section tsd-is-not-exported">
-						<h3>Variables</h3>
-						<ul class="tsd-index-list">
-							<li class="tsd-kind-variable tsd-is-not-exported"><a href="globals.html#args" class="tsd-kind-icon">args</a></li>
-						</ul>
-					</section>
 				</div>
 			</section>
 		</section>
-		<section class="tsd-panel-group tsd-member-group tsd-is-not-exported">
-			<h2>Variables</h2>
-			<section class="tsd-panel tsd-member tsd-kind-variable tsd-is-not-exported">
-				<a name="args" class="tsd-anchor"></a>
-				<h3><span class="tsd-flag ts-flagConst">Const</span> args</h3>
-				<div class="tsd-signature tsd-kind-icon">args<span class="tsd-signature-symbol">:</span> <span class="tsd-signature-type">string</span><span class="tsd-signature-symbol">[]</span><span class="tsd-signature-symbol"> =&nbsp;process.env.CI &#x3D;&#x3D;&#x3D; &#x27;true&#x27;? [&#x27;--disable-dev-shm-usage&#x27;, &#x27;--disable-setuid-sandbox&#x27;, &#x27;--no-sandbox&#x27;]: []</span></div>
-				<aside class="tsd-sources">
-					<ul>
-						<li>Defined in <a href="https://github.com/clebert/pageobject/blob/master/@pageobject/todomvc/src/TodoMVC.ts#L9">TodoMVC.ts:9</a></li>
-					</ul>
-				</aside>
-			</section>
-		</section>
 		<footer>
 			<div class="container">
 				<h2>Legend</h2>