feat: improve adapter api

@pageobject/class/src/AdapterMock.ts

@@ -6,7 +6,5 @@ export class AdapterMock<TElement> implements Adapter<TElement> {
   public readonly evaluate: jest.Mock<Promise<any>> = jest.fn();
   public readonly findElements: jest.Mock<Promise<TElement[]>> = jest.fn();
   public readonly isVisible: jest.Mock<Promise<boolean>> = jest.fn();
-  public readonly open: jest.Mock<Promise<void>> = jest.fn();
-  public readonly quit: jest.Mock<Promise<void>> = jest.fn();
   public readonly type: jest.Mock<Promise<void>> = jest.fn();
 }

@pageobject/class/src/AdapterTestSuite.ts

@@ -26,12 +26,13 @@ export abstract class AdapterTestSuite<
   TElement,
   TAdapter extends Adapter<TElement>
 > {
-  public abstract createAdapter(): Promise<TAdapter>;
+  public abstract setUp(url: string): Promise<TAdapter>;
+  public abstract tearDown(adapter: TAdapter): Promise<void>;
 
   public async runTests(): Promise<void> {
-    const adapter = await this.createAdapter();
-
-    await adapter.open(`file://${join(__dirname, '../fixtures/index.html')}`);
+    const adapter = await this.setUp(
+      `file://${join(__dirname, '../fixtures/index.html')}`
+    );
 
     try {
       const allElements = await adapter.findElements('p');
@@ -73,7 +74,7 @@ export abstract class AdapterTestSuite<
         'foo bar baz'
       );
     } finally {
-      await adapter.quit();
+      await this.tearDown(adapter);
     }
   }
 }

@pageobject/class/src/PageObject.ts

@@ -9,8 +9,6 @@ export interface Adapter<TElement> {
   /* tslint:enable no-any */
 
   findElements(selector: string, parent?: TElement): Promise<TElement[]>;
-  open(url: string): Promise<void>;
-  quit(): Promise<void>;
   type(element: TElement, text: string, delay: number): Promise<void>;
 }
 

@pageobject/puppeteer-adapter/src/PuppeteerAdapter.ts

@@ -68,14 +68,6 @@ export class PuppeteerAdapter implements Adapter<ElementHandle> {
     return elements;
   }
 
-  public async open(url: string): Promise<void> {
-    await this.page.goto(url);
-  }
-
-  public async quit(): Promise<void> {
-    await this.browser.close();
-  }
-
   public async type(
     element: ElementHandle,
     text: string,

@pageobject/puppeteer-adapter/src/__tests__/PuppeteerAdapter.test.ts

@@ -6,8 +6,16 @@ class PuppeteerAdapterTestSuite extends AdapterTestSuite<
   ElementHandle,
   PuppeteerAdapter
 > {
-  public async createAdapter(): Promise<PuppeteerAdapter> {
-    return PuppeteerAdapter.launchChrome();
+  public async setUp(url: string): Promise<PuppeteerAdapter> {
+    const adapter = await PuppeteerAdapter.launchChrome();
+
+    await adapter.page.goto(url);
+
+    return adapter;
+  }
+
+  public async tearDown(adapter: PuppeteerAdapter): Promise<void> {
+    await adapter.browser.close();
   }
 }
 

@pageobject/selenium-adapter/src/SeleniumAdapter.ts

@@ -49,14 +49,6 @@ export class SeleniumAdapter implements Adapter<WebElement> {
     return (parent || this.driver).findElements(By.css(selector));
   }
 
-  public async open(url: string): Promise<void> {
-    await this.driver.navigate().to(url);
-  }
-
-  public async quit(): Promise<void> {
-    await this.driver.quit();
-  }
-
   public async type(
     element: WebElement,
     text: string,

@pageobject/selenium-adapter/src/__tests__/SeleniumAdapter.test.ts

@@ -9,8 +9,16 @@ class SeleniumAdapterTestSuite extends AdapterTestSuite<
   WebElement,
   SeleniumAdapter
 > {
-  public async createAdapter(): Promise<SeleniumAdapter> {
-    return SeleniumAdapter.launchHeadlessChrome();
+  public async setUp(url: string): Promise<SeleniumAdapter> {
+    const adapter = await SeleniumAdapter.launchHeadlessChrome();
+
+    await adapter.driver.navigate().to(url);
+
+    return adapter;
+  }
+
+  public async tearDown(adapter: SeleniumAdapter): Promise<void> {
+    await adapter.driver.quit();
   }
 }