Tests for polygons missing inner or outer boundary

cleder · Jan 29, 2024 · 5839fe3 · 5839fe3
1 parent 1c6e51d
commit 5839fe3
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 2 deletions.
diff --git a/fastkml/geometry.py b/fastkml/geometry.py
@@ -148,8 +148,6 @@ def _etree_coordinates(
             Element,
             config.etree.Element(f"{self.ns}coordinates"),  # type: ignore[attr-defined]
         )
-        if not coordinates:
-            return element
         if len(coordinates[0]) == 2:
             tuples = (f"{c[0]:f},{c[1]:f}" for c in coordinates)
         elif len(coordinates[0]) == 3:

diff --git a/tests/geometries/point_test.py b/tests/geometries/point_test.py
@@ -151,6 +151,16 @@ def test_from_string_invalid_coordinates_non_numerical(self) -> None:
                 ns="",
             )
 
+    def test_from_string_invalid_coordinates_nan(self) -> None:
+        with pytest.raises(
+            KMLParseError,
+            match=(r"^Invalid coordinates in"),
+        ):
+            Point.class_from_string(
+                "<Point><coordinates>a,b</coordinates></Point>",
+                ns="",
+            )
+
 
 class TestPointLxml(Lxml, TestPoint):
     """Test with lxml."""
diff --git a/tests/geometries/polygon_test.py b/tests/geometries/polygon_test.py
@@ -93,6 +93,36 @@ def test_from_string_interiors_only(self) -> None:
         with pytest.raises(KMLParseError, match=r"^Missing outerBoundaryIs in <"):
             Polygon.class_from_string(doc)
 
+    def test_from_string_exterior_wo_linearring(self) -> None:
+        """Test exterior when no LinearRing in outer boundary."""
+        doc = """<kml:Polygon xmlns:kml="http://www.opengis.net/kml/2.2">
+          <kml:outerBoundaryIs>
+            <kml:coordinates>0.000000,0.000000 1.000000,0.000000 1.000000,1.000000
+            0.000000,0.000000</kml:coordinates>
+          </kml:outerBoundaryIs>
+          </kml:Polygon>"""
+
+        with pytest.raises(KMLParseError, match=r"^Missing LinearRing in <"):
+            Polygon.class_from_string(doc)
+
+    def test_from_string_interior_wo_linearring(self) -> None:
+        """Test interior when no LinearRing in inner boundary."""
+        doc = """<kml:Polygon xmlns:kml="http://www.opengis.net/kml/2.2">
+        <kml:outerBoundaryIs>
+            <kml:LinearRing>
+              <kml:coordinates>0.000000,0.000000 1.000000,0.000000 1.000000,1.000000
+              0.000000,0.000000</kml:coordinates>
+            </kml:LinearRing>
+          </kml:outerBoundaryIs>
+        <kml:innerBoundaryIs>
+        <kml:coordinates>0.000000,0.000000 1.000000,0.000000 1.000000,1.000000
+        0.000000,0.000000</kml:coordinates>
+        </kml:innerBoundaryIs>
+        </kml:Polygon>"""
+
+        with pytest.raises(KMLParseError, match=r"^Missing LinearRing in <"):
+            Polygon.class_from_string(doc)
+
     def test_from_string_exterior_interior(self) -> None:
         doc = """<kml:Polygon xmlns:kml="http://www.opengis.net/kml/2.2">
           <kml:outerBoundaryIs>