Skip to content

Commit

Permalink
'Refactored by Sourcery'
Browse files Browse the repository at this point in the history
  • Loading branch information
Sourcery AI committed Dec 7, 2022
1 parent 088e97c commit dd1138a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 14 deletions.
3 changes: 1 addition & 2 deletions fastkml/kml.py
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,7 @@ def snippet(self):
if not self._snippet:
return
if isinstance(self._snippet, dict):
text = self._snippet.get("text")
if text:
if text := self._snippet.get("text"):
assert isinstance(text, str)
max_lines = self._snippet.get("maxLines", None)
if max_lines is None:
Expand Down
8 changes: 3 additions & 5 deletions fastkml/times.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def parse_str(self, datestr: str) -> List[Union[datetime, str]]:
year = int(datestr.split("-")[0])
month = int(datestr.split("-")[1])
dt = datetime(year, month, day)
elif len(datestr) in [8, 10]:
elif len(datestr) in {8, 10}:
resolution = "date"
dt = dateutil.parser.parse(datestr)
elif len(datestr) > 10:
Expand Down Expand Up @@ -173,13 +173,11 @@ def from_element(self, element: Element) -> None:
def etree_element(self) -> Element:
element = super().etree_element()
if self.begin is not None:
text = self.date_to_string(*self.begin)
if text:
if text := self.date_to_string(*self.begin):
begin = config.etree.SubElement(element, f"{self.ns}begin")
begin.text = text
if self.end is not None:
text = self.date_to_string(*self.end)
if text:
if text := self.date_to_string(*self.end):
end = config.etree.SubElement(element, f"{self.ns}end")
end.text = text
if self.begin == self.end is None:
Expand Down
10 changes: 3 additions & 7 deletions fastkml/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ def timestamp(self, dt):

@property
def begin(self):
if self._timespan is None:
return None
return self._timespan.begin[0]
return None if self._timespan is None else self._timespan.begin[0]

@begin.setter
def begin(self, dt) -> None:
Expand Down Expand Up @@ -229,11 +227,9 @@ def from_element(self, element):
if tilt is not None:
self.tilt = tilt.text
altitude_mode = element.find(f"{self.ns}altitudeMode")
if altitude_mode is not None:
self.altitude_mode = altitude_mode.text
else:
if altitude_mode is None:
altitude_mode = element.find(f"{gx.NS}altitudeMode")
self.altitude_mode = altitude_mode.text
self.altitude_mode = altitude_mode.text
timespan = element.find(f"{self.ns}TimeSpan")
if timespan is not None:
s = TimeSpan(self.ns)
Expand Down

0 comments on commit dd1138a

Please sign in to comment.