Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary getters and setters #286

Closed
cleder opened this issue Nov 27, 2023 · 1 comment
Closed

Remove unnecessary getters and setters #286

cleder opened this issue Nov 27, 2023 · 1 comment
Labels
good first issue improvement
Milestone
Version 1.0

Comments

@cleder
Copy link
Owner

cleder commented Nov 27, 2023

Many attributes have a @property and @...setter methods. Remove the getters and setters for attributes that do not require this indirection
@cleder cleder added this to the Version 1.0 milestone Nov 27, 2023
@lchauha
Copy link

lchauha commented Nov 30, 2023

Hi @cleder I would like to work on this issue. Can you please assign this to me?

cleder added a commit that referenced this issue Dec 20, 2023
@cleder
remove unnecessary getters and setters #286 in features
48b6bfe
cleder added a commit that referenced this issue Dec 20, 2023
@cleder
remove unnecessary getters and setters #286 in views
f5fbacf
cleder added a commit that referenced this issue Dec 20, 2023
@cleder
remove unnecessary getters and setters #286 in containers
7c4e36a
cleder added a commit that referenced this issue Dec 20, 2023
@cleder
Refactor containers and kml class #286
fc183b7
cleder added a commit that referenced this issue Dec 21, 2023
@cleder
Refactor XML subelement functions in fastkml/helpers.py and fastkml/c…
17f6041 
…ontainers.py #286
cleder added a commit that referenced this issue Dec 21, 2023
@cleder
Refactor styles.py #286
9c95ed1
cleder added a commit that referenced this issue Dec 21, 2023
@cleder
Refactor geometry #286
54467e8
cleder added a commit that referenced this issue Dec 21, 2023
@cleder
Refactor Atom class to use helper functions for subelements #286
422d600
@cleder cleder closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue improvement
Projects
FastKML
Status: Done
Milestone
Version 1.0
Development

No branches or pull requests
2 participants
@cleder @lchauha