Minor test case additions & lxml warning #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
IanLee1521
commented
Jul 16, 2014
IanLee1521
commented
- Added a few tests to show what kml is produced by adding a style to both a kml.Document and kml.Placemark. Also expose a few different ways to generate the same desired kml output string.
- Added logger in fastkml.config which logs a warning if lxml is missing. This indicates that the pretty printing will not work (no newline / '\n' characters will be inserted). This was a tricky thing that took me a while to figure out why the newline characters were not being added to the output kml string.
cleder
added a commit
that referenced
this pull request
Jul 16, 2014
Minor test case additions & lxml warning Thanks 8-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.