Handle case where Feature booleans are 'true' or 'false' during parsing #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'false' when parsing from string
| @@ -493,10 +493,16 @@ def from_element(self, element): | |||
| self.description = description.text | |||
| visibility = element.find('%svisibility' % self.ns) | |||
| if visibility is not None: | |||
| self.visibility = int(visibility.text) | |||
| if visibility.text in ['1', 'true']: | |||
There was a problem hiding this comment.
Not sure what the standard defines as default here, can you read it up?
There was a problem hiding this comment.
According to kml reference the default values here are:
visibility=1
open=0
And according to xsd definition for boolean:
Legal values for boolean are true, false, 1 (which indicates true), and 0 (which indicates false).
Refs:
https://developers.google.com/kml/documentation/kmlreference#feature
http://www.w3schools.com/schema/schema_dtypes_misc.asp
cleder
added a commit
that referenced
this pull request
Aug 1, 2014
Handle case where Feature booleans are 'true' or 'false' during parsing, No need to preserve the original values if they are in violation of the specification, we may need to adjust isOpen and visibility so it defaults to the specifications default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across a few kml documents that use string 'true' or 'false' for the visibility and open boolean values instead of 1 or 0. The current way of casting to int doesn't work for these. The changes I made check for the string values and force to integer 1 or 0.
I'm not sure this is the best solution as it doesn't preserve the original string values when using to_string, but it works for my needs. I thought this might be useful for others as well.