Refactor geometry (Sourcery refactored)

[sourcery-ai]

Pull Request #239 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the refactor-geometry branch, then run:

git fetch origin sourcery/refactor-geometry
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[watermelon-copilot-for-code-review]

Please login to Watermelon to see the results

[what-the-diff]

PR Summary

• Simplification of the strtobool function in fastkml/styles.py
  The function now returns 1 when it receives the input "true", and converts other values into an integer after converting them to a float. This change streamlines the function and makes it more efficient.

• Update to the ValueError condition in fastkml/styles.py
  The condition for raising a ValueError has been updated - it now also checks if the key in use is neither "highlight" nor "normal". This added condition makes error detection in the function more thorough and helps prevent incorrect key usage.

• Removal of ValueError else case in fastkml/styles.py
  The unnecessary 'else' case that raised a ValueError has been removed. This makes the function cleaner and less cluttered.

• Enhanced element variable assignment in tests/base_test.py
  The assignment process for the element variable has been updated to use an f-string instead of simple string concatenation. This not only simplifies the code, but also generally enhances performance.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7901627) 93.20% compared to head (fbee272) 93.24%.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           refactor-geometry     #241      +/-   ##
=====================================================
+ Coverage              93.20%   93.24%   +0.03%     
=====================================================
  Files                     33       33              
  Lines                   5080     5076       -4     
=====================================================
- Hits                    4735     4733       -2     
+ Misses                   345      343       -2     

Files	Coverage Δ
fastkml/styles.py	95.94% <100.00%> (+0.61%)	⬆️
tests/base_test.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ghost]

👇 Click on the image for a new way to code review

Legend

[watermelon-copilot-for-code-review]

Please login to Watermelon to see the results

[watermelon-copilot-for-code-review]

Please login to Watermelon to see the results

[sourcery-ai]

Function PolyStyle.from_element refactored with the following changes:

• Lift code into else after jump in control flow (reintroduce-else)
• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Function StyleMap.from_element refactored with the following changes:

• Merge duplicate blocks in conditional (merge-duplicate-blocks)
• Remove redundant conditional [×2] (remove-redundant-if)
• Replace multiple comparisons of same variable with in operator (merge-comparisons)

[sourcery-ai]

Function TestStdLibrary.test_base_from_element_raises refactored with the following changes:

• Use f-string instead of string concatenation (use-fstring-for-concatenation)

This removes the following comments ( why? ):

# type: ignore[attr-defined]