#263 refactor stylespy (Sourcery refactored) #272

sourcery-ai · 2023-11-18T23:55:14Z

Pull Request #271 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the 263-refactor-stylespy branch, then run:

git fetch origin sourcery/263-refactor-stylespy
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

watermelon-copilot-for-code-review · 2023-11-18T23:55:22Z

WatermelonAI Summary

AI Summary deactivated by sourcery-ai[bot]

GitHub PRs

#272 - #263 refactor stylespy (Sourcery refactored) - By sourcery-ai[bot] Just now
#1 - Sourcery refactored master branch - By sourcery-ai[bot] 3 days ago
#1 - Sourcery refactored main branch - By sourcery-ai[bot] 11 months ago

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

fastkml is an open repo and Watermelon will serve it for free.
🍉🫶
Try us on VSCodium!

what-the-diff · 2023-11-18T23:55:42Z

PR Summary

Reworks type casting in DataType convert method
The convert method, under the DataType class, has been altered. It now returns all values as strings, without any prior type casting.
Modifications in various property methods in fastkml/kml.py
A set of properties in the 'kml.py' code file have been adjusted to prevent the return of null or non-existent values. These properties include style_url, author, snippet, address and phone_number.
Updates import syntax for urlparse
Updates have been made on how urlparse is imported in the etree_element function within styles.py, specifically to urlparse.urlparse.
Alterations in get_style_by_url method
In the KML class, the get_style_by_url method is altered to utilize a generator expression. It finds the style based on the specified URL with more efficiency now.
Conditional expression in strtobool function
The strtobool function in styles.py uses a conditional expression instead of an if-else statement, optimizing the code.
Unnecessary type hints removed in StyleUrl class
Extra type hints that turn out to be redundant in StyleUrl class have been successfully removed for cleaner code.

codecov · 2023-11-18T23:55:51Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9e3e4a9) 93.05% compared to head (d3f214a) 93.13%.

Files	Patch %	Lines
fastkml/enums.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                    @@
##           263-refactor-stylespy     #272      +/-   ##
=========================================================
+ Coverage                  93.05%   93.13%   +0.08%     
=========================================================
  Files                         34       34              
  Lines                       4865     4849      -16     
=========================================================
- Hits                        4527     4516      -11     
+ Misses                       338      333       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ghost · 2023-11-18T23:56:29Z

👇 Click on the image for a new way to code review

Legend

watermelon-copilot-for-code-review · 2023-11-20T18:37:22Z

WatermelonAI Summary

AI Summary deactivated by sourcery-ai[bot]

GitHub PRs

#272 - #263 refactor stylespy (Sourcery refactored) - By sourcery-ai[bot] 1 days ago
#1 - Sourcery refactored master branch - By sourcery-ai[bot] 4 days ago
#1 - Sourcery refactored main branch - By sourcery-ai[bot] 1 years ago

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

fastkml is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

watermelon-copilot-for-code-review · 2023-11-20T18:39:26Z

WatermelonAI Summary

AI Summary deactivated by sourcery-ai[bot]

GitHub PRs

#272 - #263 refactor stylespy (Sourcery refactored) - By sourcery-ai[bot] 1 days ago
#1 - Sourcery refactored master branch - By sourcery-ai[bot] 4 days ago
#271 - #263 refactor stylespy - By cleder 1 days ago

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

fastkml is an open repo and Watermelon will serve it for free.
🍉🫶
Try us on VSCode!

watermelon-copilot-for-code-review · 2023-11-20T18:45:18Z

fastkml/kml.py

@@ -210,9 +210,7 @@ def style_url(self) -> Optional[str]:
        Returns the url only, not a full StyleUrl object.


This file contains at least one console log. Please remove any present.

watermelon-copilot-for-code-review · 2023-11-20T18:45:19Z

WatermelonAI Summary

AI Summary deactivated by sourcery-ai[bot]

GitHub PRs

#272 - #263 refactor stylespy (Sourcery refactored) - By sourcery-ai[bot] 1 days ago
#1 - Sourcery refactored master branch - By sourcery-ai[bot] 4 days ago
#267 - Fix TimeStamp and TimeSpan class to use class_from_element method (Sourcery refactored) - By sourcery-ai[bot] 1 weeks ago

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

fastkml is an open repo and Watermelon will serve it for free.
🍉🫶

sourcery-ai · 2023-11-20T18:45:18Z

fastkml/enums.py

-            return str(value)
+            return value


Function DataType.convert refactored with the following changes:

Remove unnecessary casts to int, str, float or bool (remove-unnecessary-cast)

sourcery-ai · 2023-11-20T18:45:18Z

fastkml/kml.py

-        if isinstance(self._style_url, StyleUrl):
-            return self._style_url.url
-        return None
+        return self._style_url.url if isinstance(self._style_url, StyleUrl) else None


Function _Feature.style_url refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-11-20T18:45:18Z

fastkml/kml.py

-        if self._atom_author:
-            return self._atom_author.name
-        return None
+        return self._atom_author.name if self._atom_author else None


Function _Feature.author refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-11-20T18:45:18Z

fastkml/kml.py

-            text = self._snippet.get("text")
-            if text:
+            if text := self._snippet.get("text"):


Function _Feature.snippet refactored with the following changes:

Use named expression to simplify assignment and conditional (use-named-expression)

sourcery-ai · 2023-11-20T18:45:18Z

fastkml/kml.py

-        if self._address:
-            return self._address
-        return None
+        return self._address if self._address else None


Function _Feature.address refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-11-20T18:45:18Z

fastkml/kml.py

-        if self._phone_number:
-            return self._phone_number
-        return None
+        return self._phone_number if self._phone_number else None


Function _Feature.phone_number refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-11-20T18:45:19Z

fastkml/kml.py

-        for style in self.styles():
-            if style.id == id:
-                return style
-        return None
+        return next((style for style in self.styles() if style.id == id), None)


Function Document.get_style_by_url refactored with the following changes:

Use the built-in function next instead of a for-loop (use-next)

sourcery-ai · 2023-11-20T18:45:19Z

fastkml/kml.py

-        if self._geometry is not None:
-            return self._geometry.geometry
-        return None
+        return self._geometry.geometry if self._geometry is not None else None


Function Placemark.geometry refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-11-20T18:45:19Z

fastkml/styles.py

-    if val == "true":
-        return 1
-    return int(float(val))
+    return 1 if val == "true" else int(float(val))


Function strtobool refactored with the following changes:

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)

sourcery-ai bot requested a review from cleder November 18, 2023 23:55

watermelon-copilot-for-code-review bot added the 🚨 Don't Merge label Nov 18, 2023

sourcery-ai bot force-pushed the sourcery/263-refactor-stylespy branch from 9fb3c58 to b1d1589 Compare November 20, 2023 18:37

watermelon-copilot-for-code-review bot added 🍉 Safe to Merge and removed 🚨 Don't Merge labels Nov 20, 2023

watermelon-copilot-for-code-review bot mentioned this pull request Nov 20, 2023

#263 refactor stylespy #271

Merged

sourcery-ai bot force-pushed the sourcery/263-refactor-stylespy branch from b1d1589 to 2cae864 Compare November 20, 2023 18:39

watermelon-copilot-for-code-review bot added 👀 Take a deeper dive and removed 🍉 Safe to Merge labels Nov 20, 2023

'Refactored by Sourcery'

d3f214a

sourcery-ai bot force-pushed the sourcery/263-refactor-stylespy branch from 2cae864 to d3f214a Compare November 20, 2023 18:45

watermelon-copilot-for-code-review bot added 🚨 Don't Merge and removed 👀 Take a deeper dive labels Nov 20, 2023

watermelon-copilot-for-code-review bot reviewed Nov 20, 2023

View reviewed changes

sourcery-ai bot commented Nov 20, 2023

View reviewed changes

Base automatically changed from 263-refactor-stylespy to develop November 20, 2023 18:48

sourcery-ai bot closed this Nov 20, 2023

sourcery-ai bot deleted the sourcery/263-refactor-stylespy branch November 20, 2023 18:48

watermelon-copilot-for-code-review bot mentioned this pull request Nov 20, 2023

Atom Refactor code and update dependencies (Sourcery refactored) #276

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#263 refactor stylespy (Sourcery refactored) #272

#263 refactor stylespy (Sourcery refactored) #272

sourcery-ai bot commented Nov 18, 2023 •

edited

Loading

watermelon-copilot-for-code-review bot commented Nov 18, 2023

what-the-diff bot commented Nov 18, 2023

codecov bot commented Nov 18, 2023 •

edited

Loading

ghost commented Nov 18, 2023 •

edited by ghost

Loading

Legend

watermelon-copilot-for-code-review bot commented Nov 20, 2023

watermelon-copilot-for-code-review bot commented Nov 20, 2023

watermelon-copilot-for-code-review bot Nov 20, 2023

watermelon-copilot-for-code-review bot commented Nov 20, 2023

sourcery-ai bot Nov 20, 2023

sourcery-ai bot Nov 20, 2023

sourcery-ai bot Nov 20, 2023

sourcery-ai bot Nov 20, 2023

sourcery-ai bot Nov 20, 2023

sourcery-ai bot Nov 20, 2023

sourcery-ai bot Nov 20, 2023

sourcery-ai bot Nov 20, 2023

sourcery-ai bot Nov 20, 2023

		@@ -210,9 +210,7 @@ def style_url(self) -> Optional[str]:
		Returns the url only, not a full StyleUrl object.

#263 refactor stylespy (Sourcery refactored) #272

#263 refactor stylespy (Sourcery refactored) #272

Conversation

sourcery-ai bot commented Nov 18, 2023 • edited Loading

watermelon-copilot-for-code-review bot commented Nov 18, 2023

WatermelonAI Summary

GitHub PRs

what-the-diff bot commented Nov 18, 2023

PR Summary

codecov bot commented Nov 18, 2023 • edited Loading

Codecov Report

ghost commented Nov 18, 2023 • edited by ghost Loading

Legend

watermelon-copilot-for-code-review bot commented Nov 20, 2023

WatermelonAI Summary

GitHub PRs

watermelon-copilot-for-code-review bot commented Nov 20, 2023

WatermelonAI Summary

GitHub PRs

watermelon-copilot-for-code-review bot Nov 20, 2023

Choose a reason for hiding this comment

watermelon-copilot-for-code-review bot commented Nov 20, 2023

WatermelonAI Summary

GitHub PRs

sourcery-ai bot Nov 20, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 20, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 20, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 20, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 20, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 20, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 20, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 20, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 20, 2023

Choose a reason for hiding this comment

sourcery-ai bot commented Nov 18, 2023 •

edited

Loading

codecov bot commented Nov 18, 2023 •

edited

Loading

ghost commented Nov 18, 2023 •

edited by ghost

Loading