Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 alpha 7 #277

Merged
merged 81 commits into from
Nov 21, 2023
Merged

1.0 alpha 7 #277

merged 81 commits into from
Nov 21, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Nov 21, 2023

Are we there yet?

pre-commit-ci bot and others added 30 commits October 16, 2023 16:34
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/psf/black: 23.9.1 → 23.10.0](psf/black@23.9.1...23.10.0)
- [github.com/astral-sh/ruff-pre-commit: v0.0.292 → v0.1.1](astral-sh/ruff-pre-commit@v0.0.292...v0.1.1)
[pre-commit.ci] pre-commit autoupdate
migrated setup.py into pyproject.toml #251
requirements for read the docs
Doc-string Change
Thanks, @younggentech I appreciate it :-)
Signed-off-by: Hamed Faramarzi <hamed.faramarzi@gmail.com>
updates:
- [github.com/psf/black: 23.10.0 → 23.10.1](psf/black@23.10.0...23.10.1)
- [github.com/astral-sh/ruff-pre-commit: v0.1.1 → v0.1.3](astral-sh/ruff-pre-commit@v0.1.1...v0.1.3)
feat: Use arrow instead of dateutil
cleder and others added 23 commits November 11, 2023 20:25
Fix TimeStamp and TimeSpan class to use class_from_element method
…-and-lookat

Refactor views.py to use classmethod for parsing XML elements
updates:
- [github.com/psf/black: 23.10.1 → 23.11.0](psf/black@23.10.1...23.11.0)
- [github.com/astral-sh/ruff-pre-commit: v0.1.4 → v0.1.5](astral-sh/ruff-pre-commit@v0.1.4...v0.1.5)
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/hakancelikdev/unimport: 1.0.0 → 1.1.0](hakancelikdev/unimport@1.0.0...1.1.0)
- [github.com/astral-sh/ruff-pre-commit: v0.1.5 → v0.1.6](astral-sh/ruff-pre-commit@v0.1.5...v0.1.6)
[pre-commit.ci] pre-commit autoupdate
Atom Refactor code and update dependencies
@@ -17,7 +17,7 @@ def print_child_features(element):

k = kml.KML()

with open(fname) as kml_file:
with open(fname, encoding="utf-8") as kml_file:
k.from_string(kml_file.read().encode("utf-8"))

print_child_features(k)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

@@ -88,15 +88,26 @@
from typing import Sequence

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

@ghost
Copy link

ghost commented Nov 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 67 lines in your changes are missing coverage. Please review.

Comparison is base (579f6b2) 93.18% compared to head (2b2db5a) 93.05%.

Files Patch % Lines
fastkml/kml.py 83.06% 21 Missing ⚠️
fastkml/enums.py 81.25% 12 Missing ⚠️
fastkml/geometry.py 56.52% 10 Missing ⚠️
fastkml/styles.py 94.44% 8 Missing ⚠️
fastkml/views.py 90.27% 7 Missing ⚠️
fastkml/gx.py 60.00% 4 Missing ⚠️
fastkml/data.py 97.08% 3 Missing ⚠️
fastkml/atom.py 97.18% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   93.18%   93.05%   -0.14%     
==========================================
  Files          33       33              
  Lines        4787     4838      +51     
==========================================
+ Hits         4461     4502      +41     
- Misses        326      336      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleder cleder merged commit 5329175 into main Nov 21, 2023
74 of 81 checks passed
Copy link

what-the-diff bot commented Nov 21, 2023

PR Summary

  • Python and PyPy versions updated
    The Python versions in the GitHub Actions workflow and other relevant files were updated to include recent ones, ensuring compatibility with the latest Python versions.

  • Package and dependency updates
    The dependencies installation commands were updated to include new packages for various jobs and tasks. This would improve functionality and help in making the code more efficient and extensive.

  • Addition and Adjustment of Python hooks
    A new hook for pyprojectsort was added and the versions for various packages were updated within the pre-commit configurations, improvising the code quality checks and formatting.

  • Removal and addition of new packages
    Some existing packages were removed, and new ones were introduced or updated. This would optimize the implementation and make it more efficient.

  • Inclusion of documentation configuration files
    New documentation configuration files were added, making it easier for users to understand and navigate through the project.

  • Updates in README.rst
    Changes were made to the README file to remove unnecessary information and update it with the latest information regarding badges, URLs, etc.

  • Changes in module imports
    Module imports have been updated in various files, resulting in a more maintainable and standardized ordering of imports.

  • Addition of a new module
    The fastkml.about module was added, providing the __version__ attribute for the package.

  • Class modifications in atom, base, and configurations
    Changes were made to the classes and functions within these files to include optional attributes, update methods, handle namespace prefixes and do a lot more.

  • Updates to fastkml geometry and configurations
    New classes were added, existing imports were updated, and various other changes and improvements were made to handle different types of geometries within the files.

  • Changes in fastkml.view and gx.py files
    New classes were added, existing classes and their methods were updated, unused imports, and type hints were removed, and more.

  • Updates in pyproject.toml file
    The pyproject file has been updated with sections for optional dependencies, readme, URLS and much more, thereby maintaining and managing the project dependencies better.

  • Removal of certain files
    Some files that might have been deemed unnecessary or redundant, such as requirements.txt, setup.py, test-requirements.txt, were removed.

  • Addition of new test cases
    New test cases were added in various test files for better and more extensive testing.

  • Unexpected values updates in test cases
    Many test cases were updated with new or updated values for various attributes, improving and fine-tuning the tests.

  • Updates in tox.ini
    Here, the minimum Python version was changed and other configuration were updated for more accurate and efficient testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants