Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 alpha 8 #281

Merged
merged 27 commits into from
Nov 25, 2023
Merged

1.0 alpha 8 #281

merged 27 commits into from
Nov 25, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Nov 25, 2023

Copy link

watermelon-copilot-for-code-review bot commented Nov 25, 2023

Watermelon AI Summary

This pull request focuses on a significant refactor of the kml.py module, breaking it into smaller, more manageable parts and improving the codebase. Changes include enhancements to existing classes like Icon and Region, the addition of new classes like NetworkLink and Link for better feature handling, and the removal of outdated methods. Type annotations and import statements have been updated for clarity and modernized Python practices.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Click here to login to Notion
Click here to login to Linear
Click here to login to Asana
fastkml is an open repo and Watermelon will serve it for free.
🍉🫶
Why not invite more people to your team?

Copy link

what-the-diff bot commented Nov 25, 2023

PR Summary

  • Upgrade Test Publishing Feature in Workflow

    • The team has enhanced the testing workflow. This now uses a newer and better version for publishing tests.
  • Enhanced Code Checking Process

    • A new step has been added to the code pre-checking process that ensures better code quality.
  • Updates to Core Code

    • Certain new classes and functions have been added in the core code base, enabling more functionalities.
    • Some unnecessary functions have been removed improving efficiency.
    • Advanced coding features such as "Document" and "Folder" have now been enabled for better organization of data.
  • Version Update

    • The product version number has been updated as a part of this process.
  • New Testing Assets

    • The team has introduced new testing files to ensure the added and modified functions run correctly.
  • Modifications in Existing Testing Files

    • Changes have been made to existing testing files, adjusting them according to the code modifications. This includes renaming and import adjustments for better accuracy.
  • Removed Unnecessary Code

    • Unused portions of code have been removed, improving the overall efficiency of our technology solution.

All these code updates and additions enhance the product’s capability, making it more efficient and feature-rich.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 257 lines in your changes are missing coverage. Please review.

Comparison is base (2b2db5a) 93.05% compared to head (9966ac0) 91.78%.
Report is 1 commits behind head on main.

Files Patch % Lines
fastkml/views.py 30.61% 102 Missing ⚠️
fastkml/overlays.py 67.54% 99 Missing ⚠️
fastkml/features.py 87.22% 40 Missing ⚠️
fastkml/links.py 94.20% 8 Missing ⚠️
fastkml/containers.py 95.65% 4 Missing ⚠️
fastkml/kml.py 91.11% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
- Coverage   93.05%   91.78%   -1.27%     
==========================================
  Files          33       40       +7     
  Lines        4838     4529     -309     
==========================================
- Hits         4502     4157     -345     
- Misses        336      372      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link

ghost commented Nov 25, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

1.0 alpha 8 (Sourcery refactored)
@cleder cleder merged commit ccc0839 into main Nov 25, 2023
45 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants