Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandit issues (Sourcery refactored) #88

Closed
wants to merge 11 commits into from
Closed

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Jul 15, 2020

Pull Request #87 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/cleder/fastkml pull/87/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

whatnick and others added 11 commits September 8, 2017 11:35
The file parsing does not note encoding caveats. Included this for people using files with unicode encoding. A kludge for now till proper from_file method is introduced.
Add caveat for parsing files from disk
Switched broken pypip.in badges to shields.io
PyPI uses markdawn on default, so you should set description content type.
Show the description correctly on PyPI
@pep8speaks
Copy link

Hello @sourcery-ai[bot]! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1351:80: E501 line too long (84 > 79 characters)

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Jul 15, 2020

Sourcery Code Quality Report (beta)

Merging this PR leaves code quality unchanged.

Before After Change
Quality 8.53 8.54 0.0
Complexity 3.44 3.4 -0.04
Method Length 50.64 50.58 -0.07
Lines 1504 1500 -4
Changed files Quality Before Quality After Quality Change
setup.py 9.25 9.24 -0.01 ⬇️
fastkml/geometry.py 8.0 7.99 -0.01 ⬇️
fastkml/kml.py 8.61 8.62 0.01 ⬆️

Here are some functions in these files that still need a tune-up:

File Function Quality Recommendation
fastkml/geometry.py Geometry._get_multigeometry 2.77 Reduce complexity. Split out functionality
fastkml/kml.py _Feature.from_element 3.2 Split out functionality
fastkml/kml.py _Feature.etree_element 3.27 Split out functionality
fastkml/kml.py GroundOverlay.from_element 5.53 Split out functionality
fastkml/kml.py Placemark.from_element 5.93 Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 01d559b on sourcery/pull-87 into cf005f3 on develop.

@cleder cleder closed this Sep 23, 2021
@cleder cleder deleted the sourcery/pull-87 branch September 23, 2021 13:04
Copy link
Owner

cleder commented Sep 23, 2021

Quality gate Quality gate: Passed

No issues Everything looks good
Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants