Skip to content
This repository has been archived by the owner on Dec 17, 2018. It is now read-only.

Fixed serializer injection #11

Closed
wants to merge 1 commit into from

Conversation

karolsojko
Copy link

I've fixed an error with injecting the serializer.

First error was that there is no CL\Slack\Util\PayloadSerializer but there is CL\Slack\Serializer\PayloadSerializer.
The second error was that CL\Slack\Serializer\PayloadSerializer is abstract so can't be instantiated and the ApiClient expects an instance of SerializerInterface from JMS so why not inject the jms_serializer. This makes the bundle actually work ;)

@cleentfaar
Copy link
Owner

@karolsojko I'm happy to merge any PR but I'm pretty sure you are dealing with an older version of the bundle/library package.

Please try running composer update. If the problem persists, tell me which commit hashes you are using for the cleentfaar/slack-bundle and cleentfaar/slack packages, so I can debug it a bit better.

The serializer you are referring to (the PayloadSerializer) is actually very much needed, as you will find upon updating. It might be that the namespacing I used was wrong at the time and that was why you were having errors.

I'm currently double-checking any bugs that I might have missed during recent refactorings by running it in a real-life project of mine, so more fixes may be coming soon.

Thanks for reporting!

@karolsojko
Copy link
Author

Hmm I think you're right. Previously when I required in composer the bundle in dev-master it installed slack library in 0.12.1 and now it installs in 0.13.2 which is fine now. Thanks for clarifying :)

@karolsojko karolsojko closed this Feb 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants