This repository has been archived by the owner on Dec 17, 2018. It is now read-only.
+ Fix Attachment model missing type definition for mrkdwnIn #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
getting the same error @cleentfaar, have you had chance to review this PR? Will be great to get new release with this fix |
|
just ran into this error as well. But in addition to this pr I had to add: |
|
I've imported this package into my own package and incorporated your changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing mrkdwnIn type definition got me JMS\Serializer\Exception\RuntimeException with message: "You must define a type for CL\Slack\Model\Attachment::$mrkdwnIn" when calling channel.invite API (the API returns latest posts containing attachments.) I suppose this will also occurs on other API returning attachments.