-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returning callback results when calling pipelines' train method #71
Returning callback results when calling pipelines' train method #71
Conversation
…immediate manipulation
Hi @VolodyaCO, sorry to come back to you so late. I was wondering though if we should not save the metrics in an easily readable file such as a Let me know what you think of this :) |
No worries @clementchadebec . I prefer not having side-effects such as saving things to a file. However, I see that to keep the changes consistent, one would want other It looks as though another simple solution is not to return anything and not to save anything to a file. When using such a callback, the user would access the callback history and that's it. What do you think? |
Hi @VolodyaCO, thanks for the suggestion. |
@clementchadebec sorry for the delay. I just removed the returns! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @VolodyaCO,
No worries!
Thank you so much for making these changes. Everything looks fine :)
Closes #62.
This PR is a proof of concept for returning values from callbacks which might be useful for immediate manipulation after the pipeline has been run.