Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include executable path and command line options in movie file #557

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Randomno
Copy link
Contributor

@clementgallet
Copy link
Owner

Saving the full game path will expose some of people's file architecture, including their username. Some people may not want to show that?

@Randomno
Copy link
Contributor Author

The username is often exposed as the owner of the ltm. But the need to include the whole file path is still uncertain. I asked on Discord about this before: https://discord.com/channels/726811446498820198/726811447262183477/1145440660523069450

@vadosnaprimer
Copy link
Contributor

If only the executable name is included this should be universally safe to go.

@Randomno
Copy link
Contributor Author

I'm fine to change this to game name and command line arguments (if that's what was meant). But command line args are also going to expose users' file paths for a significant proportion of movies.

@vadosnaprimer
Copy link
Contributor

Well after having judged a whole bunch of libTAS movies, I don't remember having problems with verifying the arguments part. It's already kinda rare to begin with, and when it's needed, it's usually the only way to run the thing, and authors mention it in the description.

@vadosnaprimer
Copy link
Contributor

If only the executable name is included this should be universally safe to go.

Oh and it already is!

config.setValue("game_name", context->gamename.c_str());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants