Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add option to verify subsonic server certificate. (#6060)
* Add option to verify subsonic server certificate. Defaults to true, as it is safer to have a server certificate verified, even more so, if the server is used over an insecure WAN link. During subsonic configuration the checkbox can be deactivated, so that no certificate verification will occur when talking to a subsonic server, allowing for self-signed certificates. With the proliferation of let's encrypt certificates there's probably less need for this option but it has been requested and hard-coding verify-off is IMHO bad security practice. If a valid certificate has been installed, the configuration file can be modified manually and after a restart Clementine will perform a proper server certificate verification. The patch might need some UI polishing and asks for string translations but is operational so far. * Satisfy CLang format checker. * Use QSettings' default value support. * Consistently use QSettings' default value method.
- Loading branch information
Showing
4 changed files
with
28 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters