Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix playlist not deselecting playing track when stopping #4867

Merged
merged 1 commit into from Jun 2, 2015

Conversation

TheUbuntuGuy
Copy link
Contributor

Regression from #4866

I don't know why this line was removed. It is required to tell the playlist manager to stop the glow on the playing track once it has stopped. Without it, the track will always show as playing, and the moodbars stop working.

Adding it back in doesn't seem to break the stop after every track feature from my testing.

@kiselev-dv
Copy link
Contributor

Hi I've removed this line. It breaks selecting of next track after current track stops.

@TheUbuntuGuy
Copy link
Contributor Author

I don't see how that breaks selection of the next track. In playlist.cpp, you changed stop_after_current() to return true when stop after every track is enabled. When the track stops playing, HandleStopAfter() in player.cpp fires and selects the next row to play when play is pressed again.
Isn't that what you want?

Either way, you cannot remove this call entirely. It causes the playlist to fire several events updating the state of the player, which are used by all aspects of the UI including the play scrubber, NowPlayingWidget, etc.

@kiselev-dv
Copy link
Contributor

Yeah, sorry I see that I can't just remove this call.

I've removed this line because I've tried to avoid inconvenience for user: it's not obvious which song will play next time. But I've got now playing marker behavior in wrong way.

hatstand added a commit that referenced this pull request Jun 2, 2015
Fix playlist not deselecting playing track when stopping
@hatstand hatstand merged commit ad40116 into clementine-player:master Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants