Fix loading output/device setting in Playback Settings #6087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a bug in the Playback Settings. It does successfully save the selected value for output device when you close the settings, but it does not load it if it is set to a plain sink without a device.
This is because in PlaybackSettingsPage::Load() it's comparing a invalid QVariant value to a the loaded device which is a empty string (details.device_property_value == device) which does not match.
The output device setting is now loaded. Tested on Linux. Also tested on the Qt 5 branch. On Windows this was not broken before, since there are no sinks without devices, but I've also tested to cross build and run on windows just to make sure it still works.
Fixes #5241