Switch to queue2 for probe queue and set properties #6442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the track change hang as described in #6103 which is the correct fix for the problem.
Additionally setting properties on the queue2 element so it does not cause pause to hang.
Default max-size-bytes for queue2 is 2097152, which is lower than 10485760 for queue. We also set it to unlimited on the main queue before the tee, which might be the main cause for the track change hang.
I also set max-size-buffers and max-size-time to unlimited since we set the limit on the queue element on the queue before the tee anyway.
I have tested to pause over night and it does not get stuck anymore.
Fixes #6408
Fixes #6358
Fixes #6320
Fixes #6289
Fixes #5556
Fixes #6062
Fixes #5501
Fixes #4748
Fixes #1679