Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some changes to improve user experience. Read the comment for more. #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Nirmal-Palanichamy
Copy link

First of all... Big fan Clement! :)

I love this project. But, when I was checking out the project, it felt a little buggy while creating walls. So I've added these 3 features to make it better:

  1. Disabled right click context menu within board. Previously, right click on the board would open up the context menu. This is unnecessary and so it is disabled.
  2. Separated left and right mouse button functionalities. Previously, both left and right mouse buttons could add as well as delete walls. Now, left mouse button will only be able to add walls and right mouse button will only be able to delete walls.
  3. Added mouseup and mousedown functions on body. Previously, when creating walls, it seemed to be kind of buggy. Also, when the user drags out of the page, on bringing the cursor back, it would continue to create walls. Now, mouseup function has been added to body to reduce buggy feeling and also, mouseleave function has been added to stop creating walls after leaving the page and returning back. NOTE: This was only done for normal elements and NOT special elements.

Let me know if I need to change anything before this can be merged. Cheers :)

Previously, right click on the board would open up the context menu. This is unnecessary and so it is disabled.
 Previously, both left and right mouse buttons could add as well as delete walls. Now, left mouse button will only be able to add walls and right mouse button will only be able to delete walls.
Previously, when creating walls, it seemed to be kind of buggy. Also, when the user drags out of the page, on bringing the cursor back, it would continue to create walls. Now, mouseup function has been added to body to reduce buggy feeling and also, mouseleave function has been added to stop creating walls after leaving the page and returning back. NOTE: This was only done for normal elements and NOT special elements.
@Nirmal-Palanichamy
Copy link
Author

You can try it out here: https://nirmal-palanichamy.github.io/Pathfinding-Visualizer/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant