Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TypeError: __init__() got an unexpected keyword argument 'firefox_options' #101

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

abhinav-bhardwaj
Copy link

@abhinav-bhardwaj abhinav-bhardwaj commented Oct 15, 2021

Fixes #100

Tested on
Selenium Version - 4.0.0
scrapy-selenium version - 0.0.7
Scrapy version - 2.5.1
Python version - 3.8
OS - Ubuntu 20.04.2 LTS

@RomanBukin
Copy link

RomanBukin commented Oct 15, 2021

I want to use options (for example, '-headless'), but now they are ignored.

@abhinav-bhardwaj
Copy link
Author

I want to use options (for example, '-headless'), but now they are ignored.

Did you try the latest code update that I have committed?

@Zincious
Copy link

Zincious commented Nov 6, 2021

Thanks for this, works like a charm after the file change.

@RomanBukin
Copy link

Did you try the latest code update that I have committed?

Yes, now it works. Thanks.

@damienkilgannon
Copy link

While waiting on this to be merged ... which version of selenium & scrapy-selenium don't have this issue? thanks

@KonstantinKlepikov
Copy link

so, problem is in selenium version:

the browser option parameter firefox_options was deprecated in Selenium 3.8.0

If you use newest version: i tested the package today - the problem is in place.

@k0mmsussert0d
Copy link

Hello! Any chance for this to get merged?

@samlexxy
Copy link

@clemfromspace any idea when this will be merged and updated?

@wunewww
Copy link

wunewww commented Nov 1, 2022

This PR should be merged as soon as possible. it is critical. ^ ^

@samlexxy
Copy link

samlexxy commented Nov 1, 2022

@abhinav-bhardwaj can you please review and merge this?

@abhinav-bhardwaj
Copy link
Author

@abhinav-bhardwaj can you please review and merge this?

@samlexxy actually I'm not the maintainer of this repo, so I can't merge. Though other people can review and approve this but they also can't merge.

@samlexxy
Copy link

samlexxy commented Nov 2, 2022

@abhinav-bhardwaj can you please review and merge this?

@samlexxy actually I'm not the maintainer of this repo, so I can't merge. Though other people can review and approve this but they also can't merge.

perhaps @clemfromspace will be kind enough to look into this

@ahmedraxa23
Copy link

self.driver = driver_klass(**driver_kwargs)
TypeError: WebDriver.init() got an unexpected keyword argument 'executable_path'
ANY SOLUTUION?

@samlexxy
Copy link

self.driver = driver_klass(**driver_kwargs) TypeError: WebDriver.init() got an unexpected keyword argument 'executable_path' ANY SOLUTUION?

you'll need to edit your scrapy_selenium middle file..

follow this link https://github.com/clemfromspace/scrapy-selenium/pull/101/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes with selenium-4.0.0
10 participants