Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to make job completion more flexible #63

Closed
paulocappelli-cit opened this issue Aug 9, 2023 · 2 comments
Closed

Improvements to make job completion more flexible #63

paulocappelli-cit opened this issue Aug 9, 2023 · 2 comments
Assignees
@clemlesne
Labels
enhancement New feature or request

Comments

@paulocappelli-cit
Copy link

Hi!

There is the possibility to include customization for flags:

Keda (https://keda.sh/docs/2.10/concepts/scaling-jobs/#scaledjob-spec)

  • successfulJobsHistoryLimit
  • failedJobsHistoryLimit

Job (into ScaledJob) https://kubernetes.io/docs/concepts/workloads/controllers/job/#ttl-mechanism-for-finished-jobs

  • ttlSecondsAfterFinished

The intention is to have greater flexibility on the completion of jobs/scaleJobs and greater control related to the volumes created in cloud.

Tks!
@clemlesne
Copy link
Owner

clemlesne commented Aug 13, 2023 •
edited
Loading

Thank you for your proposal 😄 Configuration options have been added (10daba5).

Default values are those from KEDA in their specs, to avoid any breaking change.

Is it what you thought about?

Documentation extract:

Parameter Description Default
pipelines.cleanup.ttl Delay until Job history will be cleaned from Kubernetes API server (see doc). Only applied to autoscaled deployments (see autoscaling.enabled). 3600 (1 hour)
pipelines.cleanup.failed Maximum of failed Jobs to keep from Kubernetes API server (see doc). Only applied to autoscaled deployments (see autoscaling.enabled). 100
pipelines.cleanup.successful Maximum of successful Jobs to keep from Kubernetes API server (see doc). Only applied to autoscaled deployments (see autoscaling.enabled). 100

clemlesne added a commit that referenced this issue Aug 13, 2023
@clemlesne
Feat: New configuration options for Jobs history cleanup
10daba5 
#63
@clemlesne clemlesne self-assigned this Aug 13, 2023
@clemlesne clemlesne added the enhancement New feature or request label Aug 13, 2023
@paulocappelli-cit
Copy link
Author

Yes!!

Tks @clemlesne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clemlesne clemlesne

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clemlesne @paulocappelli-cit