Update to VS2019 and Win10 SDK

[x87]

This should fix some build issues noted in #24

[x87]

/cc @JuniorDjjr @Deji69

[JuniorDjjr]

Maybe I already fixed it "incorrectly" in #25 ? Partially.

I use VS 2017 but I also had a few problems when compiling, and I remember having the problem exactly with CRGBA, specifically, CRGBA::CRGBA in PluginSdkExternals.cpp. It was fixed by re-declaring it in the same file:
CRGBA &CRGBA::operator=(const CRGBA &rgba) { r = rgba.r; g = rgba.g; b = rgba.b; a = rgba.a; return *this; }

So this re-declaration is probably no longer necessary, if this was the problem. I currently don't have VS 2019 here.

[thelink2012]

LGTM

[x87]

I'm bumping version to 4.4 to designate a major change

[thelink2012]

By the way, you can merge! I prefer to provide the necessary approval for the merge, but given that approval, you can merge whenever you feel like it.

[x87]

@thelink2012 @JuniorDjjr I have made a new release https://github.com/cleolibrary/CLEO4/releases/tag/v4.4.0

please give it a try before I publish it on cleo.li

[thelink2012]

Nice :) I can't test since I'm away from a Windows box, so let's wait for @JuniorDjjr

[JuniorDjjr]

You forgot to include the new IniFiles.cleo.

[JuniorDjjr]

0AEA GET_PED_REF is crashing. 4.3.24 is fine.
Unhandled exception at 0x71037882 in CLEO.asi (+0x7882): 0xC0000005: Access violation reading location 0xF7F50BC5.
I can try to debug and fix it but I need to update by VS and build tools before it.

[x87]

I removed the release for now. I will open another PR with updated plugins.

If you can debug the crash it would be helpful.

[x87]

Could it crash on a newer plugin-sdk version? I built v4.4 using DK22Pac/plugin-sdk@b38ab7b

[JuniorDjjr]

LNK1000: Internal error during IMAGE::BuildImage when trying to build, searching for it, some guys said to disable "Whole Program Optimization" or just rebuild again.

Just rebuilding: No error, but crashes with 0AEA GET_PED_REF and maybe others.
Disabling: No error, no crashes.

"Whole Program Optimization" is important, so I don't know how to proceed.
Did you also get the LNK1000 and ignored?
Tested on newest and old plugin-sdk version. The error only occurs in CLEO project.

I created a new plugin-sdk project running int ref = CPools::GetPedRef(ped); on each game ped, no build and crash problems, seems related to CLEO project itself but I'm not sure.

[JuniorDjjr]

Is there a specific reason to still use bass.dll from 2013? I compiled with the new bass.dll, I didn't test it much but it seems ok.

[x87]

Did you also get the LNK1000 and ignored?

No, I haven't got this error. I actually downloaded brand new VS2019 and Win10 SDK before building this project and I had everything set to default. Can you share a script (.cs file) that crashes on the new version?

Is there a specific reason to still use bass.dll from 2013? I compiled with the new bass.dll, I didn't test it much but it seems ok.

I didn't think about it. We could update bass.dll to the latest version. Want to open a PR?

[x87]

@JuniorDjjr please let's continue in the issue that I've just created. #28 Please share a script so I can try to reproduce the issue on my machine.

[JuniorDjjr]

Is there a specific reason to still use bass.dll from 2013? I compiled with the new bass.dll, I didn't test it much but it seems ok.

I didn't think about it. We could update bass.dll to the latest version. Want to open a PR?

Some guys on my site reported a crash in AUDIOSES.DLL when closing the game using the new bass.dll, and this only happens with MoonLoader, so, MoonLoader should do something before we update it. Tested with beta and preview versions of MoonLoader.
I sent an updated cleo.asi compiled using new bass.dll to one of them and the problem persists.