chore: Make our templates test resilient to change #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkats
force-pushed
the
templates-integration-test
branch
2 times, most recently
from
a12e924
to
00cd72d
Compare
AlexNti
approved these changes
May 22, 2023
dimkl
approved these changes
May 22, 2023
There's no need to verify that each template can be upserted. As long as we can verify that the templates.Upsert() method works for at least one template we have good enough test coverage.
gkats
force-pushed
the
templates-integration-test
branch
from
00cd72d
to
a83bca1
Compare
4 tasks
mzhong9723
added a commit
that referenced
this pull request
Jun 5, 2023
chore: Make our templates test resilient to change (#130) feat: Introduce new sync_user_attributes SAML Connection field and ability to update it feat: Update organization settings and organizations to include admin_delete_enabled
mzhong9723
added a commit
that referenced
this pull request
Jun 5, 2023
chore: Make our templates test resilient to change (#130) feat: Introduce new sync_user_attributes SAML Connection field and ability to update it feat: Update organization settings and organizations to include admin_delete_enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
There's no need to verify that each template can be upserted. As long as we can verify that the templates.Upsert() method works for at least one template we have good enough test coverage.
Related Issue (optional)