fix(backend): Add error when secret key is invalid

clerk · Jul 4, 2023 · 2ad7cf3 · 2ad7cf3
1 parent 18d507e
commit 2ad7cf3
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 20 deletions.
diff --git a/.changeset/hungry-radios-protect.md b/.changeset/hungry-radios-protect.md
@@ -0,0 +1,5 @@
+---
+'@clerk/backend': patch
+---
+
+Add a more descriptive error when secret key is invalid
diff --git a/.changeset/silent-games-joke.md b/.changeset/silent-games-joke.md
diff --git a/packages/backend/src/tokens/keys.ts b/packages/backend/src/tokens/keys.ts
@@ -208,28 +208,16 @@ async function fetchJWKSFromBAPI(apiUrl: string, key: string, apiVersion: string
   });
 
   if (!response.ok) {
-    const errors = await response.json().then(({ errors }) => {
-      if (!errors) {
-        return false;
-      }
-
-      const invalidSecretKey = getErrorObjectByCode(errors, TokenVerificationErrorCode.InvalidSecretKey);
+    const json = await response.json();
+    const invalidSecretKeyError = getErrorObjectByCode(json?.errors, TokenVerificationErrorCode.InvalidSecretKey);
 
-      if (!invalidSecretKey) {
-        return false;
-      }
-
-      return {
-        ...invalidSecretKey,
-        reason: TokenVerificationErrorReason.InvalidSecretKey,
-      };
-    });
+    if (invalidSecretKeyError) {
+      const reason = TokenVerificationErrorReason.InvalidSecretKey;
 
-    if (errors) {
       throw new TokenVerificationError({
         action: TokenVerificationErrorAction.ContactSupport,
-        message: errors.message,
-        reason: errors.reason,
+        message: invalidSecretKeyError.message,
+        reason,
       });
     }
 

diff --git a/packages/backend/src/util/request.ts b/packages/backend/src/util/request.ts
@@ -86,5 +86,9 @@ type ErrorFields = {
 };
 
 export const getErrorObjectByCode = (errors: ErrorFields[], code: string) => {
+  if (!errors) {
+    return null;
+  }
+
   return errors.find((err: ErrorFields) => err.code === code);
 };