Skip to content

Commit

Permalink
chore(repo): Remove eslint-config-custom from react's deps (#3307)
Browse files Browse the repository at this point in the history
* chore(repo): Remove eslint-config-custom from react's deps

* chore(repo): Adds changeset

* chore(repo): Update package.json

* chore(repo): Rename eslint-config-custom to @clerk/eslint-config-custom
  • Loading branch information
BRKalow committed May 7, 2024
1 parent f70c885 commit 39265d9
Show file tree
Hide file tree
Showing 42 changed files with 76 additions and 64 deletions.
6 changes: 6 additions & 0 deletions .changeset/calm-lemons-compare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@clerk/eslint-config-custom': patch
'@clerk/clerk-react': patch
---

Rename local `eslint-config-custom` package to `@clerk/eslint-config-custom` to avoid conflicts with previously published package. Removes `eslint-config-custom` from `@clerk/clerk-react`'s dependencies, as it should only be a development dependency.
5 changes: 5 additions & 0 deletions .changeset/real-books-turn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/eslint-config-custom': patch
---

Initial release of `@clerk/eslint-config-custom`, for internal use.
2 changes: 1 addition & 1 deletion integration/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const disabledRules = {
module.exports = {
root: true,
ignorePatterns: ['!.*.js', '*.snap', 'templates/**'],
extends: ['custom/node', 'custom/typescript', 'custom/playwright'],
extends: ['@clerk/custom/node', '@clerk/custom/typescript', '@clerk/custom/playwright'],
rules: {
...disabledRules,
},
Expand Down
45 changes: 22 additions & 23 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
"cross-spawn": "^7.0.3",
"dotenv": "^16.3.1",
"eslint": "^8.49.0",
"eslint-config-custom": "*",
"execa": "^5.1.1",
"expect-type": "^0.16.0",
"fastify": "4.12.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = {
root: true,
extends: ['custom/node', 'custom/typescript', 'custom/qunit'],
extends: ['@clerk/custom/node', '@clerk/custom/typescript', '@clerk/custom/qunit'],
rules: {
'import/no-unresolved': ['error', { ignore: ['^#'] }],
},
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
"tslib": "2.4.1"
},
"devDependencies": {
"@clerk/eslint-config-custom": "*",
"@clerk/types": "4.2.0",
"@cloudflare/workers-types": "^3.18.0",
"@types/chai": "^4.3.3",
Expand All @@ -112,7 +113,6 @@
"edge-runtime": "^2.5.9",
"esbuild": "^0.15.12",
"esbuild-register": "^3.3.3",
"eslint-config-custom": "*",
"miniflare": "^2.14.2",
"npm-run-all": "^4.1.5",
"qunit": "^2.19.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/chrome-extension/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module.exports = {
root: true,
extends: ['custom/browser', 'custom/typescript', 'custom/jest', 'custom/react'],
extends: ['@clerk/custom/browser', '@clerk/custom/typescript', '@clerk/custom/jest', '@clerk/custom/react'],
};
2 changes: 1 addition & 1 deletion packages/chrome-extension/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@
"webextension-polyfill": "^0.10.0"
},
"devDependencies": {
"@clerk/eslint-config-custom": "*",
"@types/chrome": "*",
"@types/node": "^18.17.0",
"@types/react": "*",
"@types/react-dom": "*",
"@types/webextension-polyfill": "^0.10.7",
"eslint-config-custom": "*",
"tsup": "*",
"type-fest": "^4.8.3",
"typescript": "*"
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = {
root: true,
extends: ['custom/browser', 'custom/typescript', 'custom/jest', 'custom/react'],
extends: ['@clerk/custom/browser', '@clerk/custom/typescript', '@clerk/custom/jest', '@clerk/custom/react'],
rules: {
'jest/no-test-prefixes': 'warn', // TODO: Remove this once we've fixed all the tests
},
Expand Down
2 changes: 1 addition & 1 deletion packages/clerk-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"@babel/preset-env": "^7.12.1",
"@babel/preset-react": "^7.12.5",
"@babel/preset-typescript": "^7.12.1",
"@clerk/eslint-config-custom": "*",
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.10",
"@svgr/webpack": "^6.2.1",
"@types/qs": "^6.9.3",
Expand All @@ -84,7 +85,6 @@
"babel-loader": "^9.1.2",
"babel-plugin-module-resolver": "^5.0.0",
"bundlewatch": "^0.3.3",
"eslint-config-custom": "*",
"react-refresh": "^0.14.0",
"react-refresh-typescript": "^2.0.5",
"terser-webpack-plugin": "^5.3.10",
Expand Down
2 changes: 1 addition & 1 deletion packages/elements/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = {
root: true,
extends: ['custom/browser', 'custom/typescript', 'custom/jest', 'custom/react'],
extends: ['@clerk/custom/browser', '@clerk/custom/typescript', '@clerk/custom/jest', '@clerk/custom/react'],
rules: {
'import/no-unresolved': [2, { ignore: ['^~/'] }],
},
Expand Down
7 changes: 6 additions & 1 deletion packages/elements/examples/nextjs/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
module.exports = {
root: true,
extends: ['custom/browser', 'custom/typescript', 'custom/react', 'plugin:@next/next/recommended'],
extends: [
'@clerk/custom/browser',
'@clerk/custom/typescript',
'@clerk/custom/react',
'plugin:@next/next/recommended',
],
};
2 changes: 1 addition & 1 deletion packages/elements/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,13 @@
},
"devDependencies": {
"@clerk/clerk-react": "5.0.3",
"@clerk/eslint-config-custom": "*",
"@clerk/shared": "2.0.1",
"@clerk/types": "^4.2.0",
"@types/node": "^18.17.0",
"@types/react": "*",
"@types/react-dom": "*",
"concurrently": "^8.2.2",
"eslint-config-custom": "*",
"next": "^14.2.3",
"tslib": "2.4.1",
"tsup": "*",
Expand Down

0 comments on commit 39265d9

Please sign in to comment.