Skip to content

Commit

Permalink
fix(clerk-js): Fix button font size for alternative methods on <SignI…
Browse files Browse the repository at this point in the history
…n/> (#2997)
  • Loading branch information
octoper committed Mar 14, 2024
1 parent 2684f1d commit 94bbdf7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/great-seals-punch.md
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Fix font size inconsistencies when selecting method to sign in.
Expand Up @@ -88,6 +88,7 @@ const AlternativeMethodsList = (props: AlternativeMethodListProps) => {
textElementDescriptor={descriptors.alternativeMethodsBlockButtonText}
arrowElementDescriptor={descriptors.alternativeMethodsBlockButtonArrow}
key={i}
textVariant='buttonLarge'
isDisabled={card.isLoading}
onClick={() => onFactorSelected(factor)}
/>
Expand Down
4 changes: 3 additions & 1 deletion packages/clerk-js/src/ui/elements/ArrowBlockButton.tsx
Expand Up @@ -22,6 +22,7 @@ type ArrowBlockButtonProps = PropsOfComponent<typeof Button> & {
spinnerElementDescriptor?: ElementDescriptor;
spinnerElementId?: ElementId;
textLocalizationKey?: LocalizationKey | string;
textVariant?: PropsOfComponent<typeof Text>['variant'];
};

export const ArrowBlockButton = React.forwardRef<HTMLButtonElement, ArrowBlockButtonProps>((props, ref) => {
Expand All @@ -43,6 +44,7 @@ export const ArrowBlockButton = React.forwardRef<HTMLButtonElement, ArrowBlockBu
textLocalizationKey,
childrenSx,
badge,
textVariant = 'buttonSmall',
...rest
} = props;

Expand Down Expand Up @@ -116,7 +118,7 @@ export const ArrowBlockButton = React.forwardRef<HTMLButtonElement, ArrowBlockBu
elementId={textElementId}
as='span'
truncate
variant='buttonSmall'
variant={textVariant}
localizationKey={textLocalizationKey}
>
{children}
Expand Down

0 comments on commit 94bbdf7

Please sign in to comment.