New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non browsers requests to satellite apps should not throw intestitial #1433
Conversation
🦋 Changeset detectedLatest commit: 619f780 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆
!snapshot |
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.23.7-snapshot.3f63646 # @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.18 # @clerk/clerk-js
npm i @clerk/clerk-js@4.51.0 # eslint-config-custom
npm i eslint-config-custom@0.3.0 # @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.9 # @clerk/fastify
npm i @clerk/fastify@0.5.6-snapshot.3f63646 # gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.19-snapshot.3f63646 # @clerk/localizations
npm i @clerk/localizations@1.22.0 # @clerk/nextjs
npm i @clerk/nextjs@4.21.13-snapshot.3f63646 # @clerk/clerk-react
npm i @clerk/clerk-react@4.21.0 # @clerk/remix
npm i @clerk/remix@2.6.16-snapshot.3f63646 # @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.14-snapshot.3f63646 # @clerk/shared
npm i @clerk/shared@0.19.1 # @clerk/themes
npm i @clerk/themes@1.7.5 # @clerk/types
npm i @clerk/types@3.46.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 let's add a test case (i think we should also update the flow diagram) and merge this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock if you decide to tackle the comments here :)
!snapshot |
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.23.7-snapshot.a1cee25 # @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.18 # @clerk/clerk-js
npm i @clerk/clerk-js@4.51.0 # eslint-config-custom
npm i eslint-config-custom@0.3.0 # @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.9 # @clerk/fastify
npm i @clerk/fastify@0.5.6-snapshot.a1cee25 # gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.3.19-snapshot.a1cee25 # @clerk/localizations
npm i @clerk/localizations@1.22.0 # @clerk/nextjs
npm i @clerk/nextjs@4.21.13-snapshot.a1cee25 # @clerk/clerk-react
npm i @clerk/clerk-react@4.21.0 # @clerk/remix
npm i @clerk/remix@2.6.16-snapshot.a1cee25 # @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.10.14-snapshot.a1cee25 # @clerk/shared
npm i @clerk/shared@0.19.1 # @clerk/themes
npm i @clerk/themes@1.7.5 # @clerk/types
npm i @clerk/types@3.46.1 |
…ld be treated as signed out This is necessary, because tools like `opengraph.xyz` will not follow redirects, and they will always end up with parsing our interstitial template.
Requests to satellite apps visited by non browsers should be treated as signed out
This is necessary, because tools like
opengraph.xyz
will not follow redirects, and they will always end up with parsing our interstitial template.Type of change
Packages affected
@clerk/clerk-js
@clerk/clerk-react
@clerk/nextjs
@clerk/remix
@clerk/types
@clerk/themes
@clerk/localizations
@clerk/clerk-expo
@clerk/backend
@clerk/clerk-sdk-node
@clerk/shared
@clerk/fastify
@clerk/chrome-extension
gatsby-plugin-clerk
build/tooling/chore
Description
npm test
runs as expected.npm run build
runs as expected.