Use CLERK_TRUST_HOST by default #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 874c165 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
dimkl
changed the title
nikosdouvlis
approved these changes
Jul 19, 2023
dimkl
force-pushed
the
js-513-clerk-trust-host
branch
from
55aba10
to
c05e4b3
Compare
dimkl
changed the title
dimkl
force-pushed
the
js-513-clerk-trust-host
branch
from
c05e4b3
to
12bec2e
Compare
dimkl
commented
Jul 19, 2023
packages/backend/src/utils.ts
Outdated
|
|
||
| // TODO: replace Request type with runtime.Request | ||
| // import type runtime from './runtime'; | ||
| // type Request = typeof runtime.Request |
There was a problem hiding this comment.
After some discussion with @anagstef we have decided that I will remove these comments and keep the Request type in the code below.
@nikosdouvlis should we proceed with that?
dimkl
force-pushed
the
js-513-clerk-trust-host
branch
2 times, most recently
from
4d7221c
to
01e99a4
Compare
dimkl
commented
Jul 19, 2023
dimkl
commented
Jul 19, 2023
| }); | ||
| afterAll(() => { | ||
| global.console.warn = consoleWarn; | ||
| }); |
There was a problem hiding this comment.
I have disabled the console.warn from authMiddleware.test.ts test to reduce the noise in our test results
cc: @nikosdouvlis , @anagstef
dimkl
commented
Jul 19, 2023
dimkl
force-pushed
the
js-513-clerk-trust-host
branch
from
b878d15
to
7c42025
Compare
dimkl
commented
Jul 19, 2023
dimkl
force-pushed
the
js-513-clerk-trust-host
branch
from
5215245
to
b5f1337
Compare
|
!snapshot |
|
Hey @dimkl - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/backend@0.26.0-snapshot.b5f1337# @clerk/chrome-extension
npm i @clerk/chrome-extension@0.3.23# @clerk/clerk-js
npm i @clerk/clerk-js@4.54.0# eslint-config-custom
npm i eslint-config-custom@0.3.0# @clerk/clerk-expo
npm i @clerk/clerk-expo@0.18.14# @clerk/fastify
npm i @clerk/fastify@0.6.2-snapshot.b5f1337# gatsby-plugin-clerk
npm i gatsby-plugin-clerk@4.4.2-snapshot.b5f1337# @clerk/localizations
npm i @clerk/localizations@1.23.1# @clerk/nextjs
npm i @clerk/nextjs@4.23.0-snapshot.b5f1337# @clerk/clerk-react
npm i @clerk/clerk-react@4.23.0# @clerk/remix
npm i @clerk/remix@2.9.0-snapshot.b5f1337# @clerk/clerk-sdk-node
npm i @clerk/clerk-sdk-node@4.12.0-snapshot.b5f1337# @clerk/shared
npm i @clerk/shared@0.20.0# @clerk/themes
npm i @clerk/themes@1.7.5# @clerk/types
npm i @clerk/types@3.48.0 |
The buildRequestUrl utility will be used to construct the request url using a request and optional path parameter (used to overrided the path of the request url). This utility will use the forwarded headers values and the request.url to generate and return the actual request URL
…is already of type Request
dimkl
force-pushed
the
js-513-clerk-trust-host
branch
from
b5f1337
to
874c165
Compare
nikosdouvlis
approved these changes
Jul 20, 2023
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.