fix(shared, nextjs): Support importing @clerk/shared in @clerk/nextjs #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 921892f The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
24 tasks
panteliselef
approved these changes
Sep 22, 2023
|
Sorry didn't mean to approve, just to add a comment. |
|
@panteliselef do know mean this runtime error ?: #1760 (comment) |
yes, that one |
anagstef
approved these changes
Sep 25, 2023
dimkl
force-pushed
the
fix-shared-deps-in-nextjs
branch
from
8c7279f
to
a7c2274
Compare
24 tasks
BRKalow
reviewed
Sep 27, 2023
dimkl
force-pushed
the
fix-shared-deps-in-nextjs
branch
2 times, most recently
from
b9df973
to
39a24a0
Compare
This change will resolve the following issue we had when importing
@clerk/shared in @clerk/nextjs:
```
Your're importing a component that needs useState. It only works in
a Client Component none of its parents are marked with "use client",
so they're Server Components by default.
[javascript/packages/shared/src/hooks/usePagesOrInfinite.js:1:1]
import { useCallback, useMemo, useRef, useState } from "react";
```
dimkl
force-pushed
the
fix-shared-deps-in-nextjs
branch
from
39a24a0
to
5864bc7
Compare
…variable deprecation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review it per commit
Use
use clientdirective in @clerk/shared to support importing it in libraries compatible with RSC and use package in @clerk/nextjs (also replaced current copy/pasted code).Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore