Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend,clerk-js,types): Support the new LinkedIn OAuth Provider #1772

Merged
merged 1 commit into from
Oct 10, 2023
Merged

feat(backend,clerk-js,types): Support the new LinkedIn OAuth Provider #1772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/serious-zebras-sip.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@clerk/clerk-js': minor
'@clerk/backend': minor
'@clerk/types': minor
---

Add support for LinkedIn OIDC
1 change: 1 addition & 0 deletions packages/backend/src/api/resources/Enums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export type OAuthProvider =
| 'twitter'
| 'twitch'
| 'linkedin'
| 'linkedin_oidc'
| 'dropbox'
| 'bitbucket'
| 'microsoft'
Expand Down
1 change: 1 addition & 0 deletions packages/clerk-js/src/ui/utils/test/fixtures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ const socials = Object.freeze(
'oauth_twitter',
'oauth_twitch',
'oauth_linkedin',
'oauth_linkedin_oidc',
'oauth_dropbox',
'oauth_atlassian',
'oauth_bitbucket',
Expand Down
8 changes: 8 additions & 0 deletions packages/types/src/oauth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export type DiscordOauthProvider = 'discord';
export type TwitterOauthProvider = 'twitter';
export type TwitchOauthProvider = 'twitch';
export type LinkedinOauthProvider = 'linkedin';
export type LinkedinOIDCOauthProvider = 'linkedin_oidc';
export type DropboxOauthProvider = 'dropbox';
export type AtlassianOauthProvider = 'atlassian';
export type BitbucketOauthProvider = 'bitbucket';
Expand All @@ -45,6 +46,7 @@ export type OAuthProvider =
| TwitterOauthProvider
| TwitchOauthProvider
| LinkedinOauthProvider
| LinkedinOIDCOauthProvider
| DropboxOauthProvider
| AtlassianOauthProvider
| BitbucketOauthProvider
Expand Down Expand Up @@ -109,6 +111,12 @@ export const OAUTH_PROVIDERS: OAuthProviderData[] = [
name: 'LinkedIn',
docsUrl: 'https://clerk.com/docs/authentication/social-connection-with-linkedin',
},
{
provider: 'linkedin_oidc',
strategy: 'oauth_linkedin_oidc',
name: 'LinkedIn',
docsUrl: 'https://clerk.com/docs/authentication/social-connections/linkedin-oidc',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not exist yet, right? Are we adding it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desiprisg Yes: clerk/clerk-docs#342

},
{
provider: 'github',
strategy: 'oauth_github',
Expand Down