Introduce internal Gate component #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: 3c1a648 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
commented
Oct 6, 2023
| @@ -18,6 +19,8 @@ export class OrganizationMembership extends BaseResource implements Organization | |||
| publicMetadata: OrganizationMembershipPublicMetadata = {}; | |||
| publicUserData!: PublicUserData; | |||
| organization!: Organization; | |||
| // eslint-disable-next-line | |||
There was a problem hiding this comment.
Note: adding (string & {}) allows for getting eslint autocomplete but also accepts any string
There was a problem hiding this comment.
Should we write this in a comment?
panteliselef
commented
Oct 6, 2023
| if (domain) { | ||
| setData({ ...domain }); | ||
| callbacks?.onSuccess?.({ ...domain }); | ||
| if (typeof result !== 'undefined') { |
There was a problem hiding this comment.
Note for reviewer: if value is an object then do a shallow copy otherwise use the actual value
panteliselef
changed the title
panteliselef
force-pushed
the
ORG-248
branch
2 times, most recently
from
da0696a
to
28afb35
Compare
desiprisg
reviewed
Oct 6, 2023
.changeset/loud-foxes-love.md
Outdated
| '@clerk/types': patch | ||
| --- | ||
|
|
||
| Introduces a new method isAuthorized in the Session class. Returns a promise and checks whether the active user is allowed to perform an action based on the passed (required) permission and the ones attached to the membership. |
There was a problem hiding this comment.
Suggested change
| Introduces a new method isAuthorized in the Session class. Returns a promise and checks whether the active user is allowed to perform an action based on the passed (required) permission and the ones attached to the membership. | |
| Introduces a new `isAuthorized()` method in the `Session` class. Returns a promise and checks whether the active user is allowed to perform an action based on the passed (required) permission and the ones attached to the membership. |
desiprisg
reviewed
Oct 6, 2023
.changeset/proud-dolls-yawn.md
Outdated
| '@clerk/clerk-js': patch | ||
| --- | ||
|
|
||
| Introduces an internal Gate component (supporting hook and HOC) which enables us to conditionally render parts of our components based on a users permissions. |
There was a problem hiding this comment.
Suggested change
| Introduces an internal Gate component (supporting hook and HOC) which enables us to conditionally render parts of our components based on a users permissions. | |
| Introduces an internal `<Gate/>` component (supporting hook and HOC) which enables us to conditionally render parts of our components based on a users permissions. |
octoper
approved these changes
Oct 9, 2023
chanioxaris
approved these changes
Oct 9, 2023
desiprisg
approved these changes
Oct 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
isAuthorizedin theSessionclass. Returns a promise (future proofing) and checks whether the active user is allowed to perform an action based on the passed (required) permission and the ones attached to the membership.isAdminchecks)Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore