fix(backend,clerk-sdk-node): Fix noisy deprecations sdk node #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3bb935d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
24 tasks
dimkl
force-pushed
the
fix-noisy-deprecations-sdk-node
branch
2 times, most recently
from
d068676
to
ca60398
Compare
dimkl
force-pushed
the
fix-noisy-deprecations-sdk-node
branch
from
ca60398
to
3bb935d
Compare
BRKalow
reviewed
Oct 10, 2023
| @@ -26,7 +26,7 @@ export const loadClientEnv = () => { | |||
| export const loadApiEnv = () => { | |||
| return { | |||
| secretKey: process.env.CLERK_SECRET_KEY || process.env.CLERK_API_KEY || '', | |||
| apiKey: process.env.CLERK_SECRET_KEY || process.env.CLERK_API_KEY || '', | |||
There was a problem hiding this comment.
Are there usages of apiKey that assume it has been defaulted to CLERK_SECRET_KEY?
There was a problem hiding this comment.
i think it's a typo or an attempt to be "extra" safe that the env is used.
BRKalow
approved these changes
Oct 10, 2023
Merged
dimkl
changed the title
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid always showing
frontendApiandapiKeyon@clerk/clerk-sdk-node!Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore