chore(repo): Deprecate node@{14,15,16,17} versions #1864

dimkl · 2023-10-11T14:59:14Z

Description

Some information about changes for all those node versions

Node 15 : https://platform.sh/blog/nodejs-15-could-make-your-app-leaner-and-meaner/
- Logical assignment operators
- String.prototype.replaceAll
- Promise.any
- AggregateError
- AbortController
- timers/promises
- npm 7
- Workspaces
- New package-lock.json format

Node 16 : https://medium.com/the-node-js-collection/node-js-16-available-now-7f5099a97e70
- Stable Timers Promises API
- Experimental implementation of the standard Web Crypto API
- npm 7 (v7.10.0 in Node.js v16.0.0)
- Node-API version 8
- Stable AbortController implementation based on the AbortController Web API
- Stable Source Maps v3
- Web platform atob (buffer.atob(data)) and btoa (buffer.btoa(data)) implementations for compatibility with legacy web platform APIs

Node 17 : https://blog.appsignal.com/2021/10/27/what-s-new-in-nodejs-17.html
- New Promise-based APIs (dns, fs, stream, and timers)
- Stack Traces Now Include the Version of Node.js
- OpenSSL 3.0 Support
- V8 Upgraded to v9.5 : https://v8.dev/blog/v8-release-95
    - Intl.DisplayNames
    - WebAssembly Exception Handling

Node 18 : https://nodejs.org/en/blog/announcements/v18-release-announce
- V8 Upgraded to 10.1
    - Array: findLast and findLastIndex
- Built-in Test Runner
- New Browser-compatible APIs
    - fetch
    - Streams
    - Blob - https://nodejs.org/api/buffer.html#class-blob
    - BroadcastChannel - https://nodejs.org/api/worker_threads.html#class-broadcastchannel-extends-eventtarget

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Packages affected

changeset-bot · 2023-10-11T14:59:18Z

🦋 Changeset detected

Latest commit: 8553f03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@clerk/shared	Major
gatsby-plugin-clerk	Major
@clerk/chrome-extension	Major
@clerk/clerk-js	Major
@clerk/clerk-sdk-node	Major
@clerk/backend	Major
@clerk/fastify	Major
@clerk/nextjs	Major
@clerk/themes	Major
@clerk/clerk-react	Major
@clerk/remix	Major
@clerk/types	Major
@clerk/clerk-expo	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

LekoArts

It would be good to add the engines field to all packages, e.g. shared is missing that information

For our reasoning why we chose Node 18 we should use https://github.com/nodejs/release#release-schedule for our changelog. We'll just follow the LTS plan

nikosdouvlis · 2023-10-12T08:19:55Z

It would be good to add the engines field to all packages, e.g. shared is missing that information

For our reasoning why we chose Node 18 we should use https://github.com/nodejs/release#release-schedule for our changelog. We'll just follow the LTS plan

The reason we chose Node 18 for the v5 release is outlined here: https://nodejs.org/en/blog/announcements/nodejs16-eol

dimkl · 2023-10-16T16:26:36Z

Blocked by #1837

LekoArts · 2023-11-06T08:23:32Z

packages/backend/README.md

@@ -48,7 +48,7 @@ This package provides Clerk Backend API resources and low-level authentication u

 ## How to use

-Works on Node >= 16 or on any V8 Isolates runtimes such as Cloudflare Workers.
+Works on Node.js `^18.18` (or later) or on any V8 Isolates runtimes (eg Cloudflare Workers).


In the README you write ^18.18 but in the engines field we have >=18.

Currently that would mean we allow ^18.0.0. So if you want to have ^18.18.0 you'll need to adjust the engines field everywhere.

LekoArts · 2023-11-06T08:25:15Z

.changeset/purple-pumas-study.md

+Upgrade all packages to node@v18 version, moved some deps to dev dependencies
+and introduced `isomorphicBtoa` helper in `@clerk/shared`.


Suggested change

Upgrade all packages to node@v18 version, moved some deps to dev dependencies

and introduced `isomorphicBtoa` helper in `@clerk/shared`.

Dropping support for Node 14 and 16 as they both reached EOL status. The minimal Node.js version required by Clerk is `18.18.0` now.

For the new helper in @clerk/shared you can add a new changeset with a minor

LekoArts · 2023-11-06T08:28:21Z

integration/templates/react-cra/package.json

    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "react-scripts": "5.0.1",
    "typescript": "^4.9.5",
    "web-vitals": "^2.1.4"
+  },
+  "devDependencies": {
+    "@types/node": "^18.18",


Nit: You write 18.18 everywhere but it would be better to also have the patch version everywhere. So if you mean 18.18.0 then use that

dimkl · 2023-11-06T08:54:09Z

@LekoArts : I will update the @types/node, engines and the README to ^18.18.0 everywhere since the v18 has entered maintenance mode and there probably won't ever be a v18.19.

dimkl · 2023-11-06T10:55:38Z

@LekoArts changes applied, ptal.

…atch version

dimkl requested a review from a team as a code owner October 11, 2023 14:59

clerk-cookie added nextjs remix backend fastify gatsby labels Oct 11, 2023

dimkl force-pushed the js-698-node-18 branch from 32e27c7 to 9207539 Compare October 11, 2023 15:09

clerk-cookie added the sdk-node label Oct 11, 2023

dimkl changed the title ~~chore(repo): Deprecate node@{14,15,16,17 versions~~ chore(repo): Deprecate node@{14,15,16,17} versions Oct 11, 2023

dimkl self-assigned this Oct 11, 2023

dimkl changed the title ~~chore(repo): Deprecate node@{14,15,16,17} versions~~ [WIP] chore(repo): Deprecate node@{14,15,16,17} versions Oct 11, 2023

dimkl added the v5-release label Oct 11, 2023

clerk-cookie added react expo chrome-extension labels Oct 11, 2023

dimkl force-pushed the js-698-node-18 branch from d5e0804 to 80509a6 Compare October 11, 2023 18:10

LekoArts marked this pull request as draft October 12, 2023 07:29

LekoArts reviewed Oct 12, 2023

View reviewed changes

dimkl force-pushed the js-698-node-18 branch from 80509a6 to b57eb53 Compare October 25, 2023 17:39

clerk-cookie added types playground themes integration labels Oct 25, 2023

dimkl force-pushed the js-698-node-18 branch from b57eb53 to cb1c7a3 Compare November 2, 2023 16:45

clerk-cookie added the clerk-js label Nov 2, 2023

dimkl force-pushed the js-698-node-18 branch 2 times, most recently from 5413517 to 20bead7 Compare November 2, 2023 16:54

dimkl changed the title ~~[WIP] chore(repo): Deprecate node@{14,15,16,17} versions~~ chore(repo): Deprecate node@{14,15,16,17} versions Nov 2, 2023

dimkl force-pushed the js-698-node-18 branch 6 times, most recently from 502b56d to 781bdcc Compare November 6, 2023 08:22

LekoArts requested changes Nov 6, 2023

View reviewed changes

dimkl force-pushed the js-698-node-18 branch from 781bdcc to a8e296c Compare November 6, 2023 09:21

dimkl requested a review from LekoArts November 6, 2023 09:21

dimkl force-pushed the js-698-node-18 branch 2 times, most recently from 7361d84 to 03d3ece Compare November 6, 2023 09:44

dimkl enabled auto-merge November 6, 2023 09:55

dimkl force-pushed the js-698-node-18 branch from 03d3ece to 8a24687 Compare November 6, 2023 10:55

dimkl added 4 commits November 6, 2023 13:21

feat(shared): Introduce isomorphicBtoa helper

484eaf7

chore(repo): Upgrade to node@18 + moved dev dependencies

e23ff6a

chore(repo): Update READMEs with node@18 prerequisite

872765b

chore(backend): Drop fetch and crypto polyfills

3135740

dimkl force-pushed the js-698-node-18 branch from 8a24687 to 6c12f2d Compare November 6, 2023 11:21

dimkl added 2 commits November 6, 2023 13:33

chore(*): Make engines, @types/node and README refs to include node p…

7a5c831

…atch version

chore(*): Add changeset

8553f03

dimkl force-pushed the js-698-node-18 branch from 6c12f2d to 8553f03 Compare November 6, 2023 11:34

LekoArts approved these changes Nov 6, 2023

View reviewed changes

dimkl added this pull request to the merge queue Nov 6, 2023

Merged via the queue into main with commit 97407d8 Nov 6, 2023
7 checks passed

dimkl deleted the js-698-node-18 branch November 6, 2023 12:40

clerk-cookie mentioned this pull request Nov 6, 2023

Version Packages (alpha-v5) #2000

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(repo): Deprecate node@{14,15,16,17} versions #1864

chore(repo): Deprecate node@{14,15,16,17} versions #1864

dimkl commented Oct 11, 2023 •

edited

changeset-bot bot commented Oct 11, 2023 •

edited

LekoArts left a comment

nikosdouvlis commented Oct 12, 2023 •

edited

dimkl commented Oct 16, 2023

LekoArts Nov 6, 2023 •

edited

LekoArts Nov 6, 2023

LekoArts Nov 6, 2023

dimkl commented Nov 6, 2023

dimkl commented Nov 6, 2023

		Upgrade all packages to node@v18 version, moved some deps to dev dependencies
		and introduced `isomorphicBtoa` helper in `@clerk/shared`.

	Upgrade all packages to node@v18 version, moved some deps to dev dependencies
	and introduced `isomorphicBtoa` helper in `@clerk/shared`.
	Dropping support for Node 14 and 16 as they both reached EOL status. The minimal Node.js version required by Clerk is `18.18.0` now.

chore(repo): Deprecate node@{14,15,16,17} versions #1864

chore(repo): Deprecate node@{14,15,16,17} versions #1864

Conversation

dimkl commented Oct 11, 2023 • edited

Description

Checklist

Type of change

Packages affected

changeset-bot bot commented Oct 11, 2023 • edited

🦋 Changeset detected

LekoArts left a comment

Choose a reason for hiding this comment

nikosdouvlis commented Oct 12, 2023 • edited

dimkl commented Oct 16, 2023

LekoArts Nov 6, 2023 • edited

Choose a reason for hiding this comment

LekoArts Nov 6, 2023

Choose a reason for hiding this comment

LekoArts Nov 6, 2023

Choose a reason for hiding this comment

dimkl commented Nov 6, 2023

dimkl commented Nov 6, 2023

dimkl commented Oct 11, 2023 •

edited

changeset-bot bot commented Oct 11, 2023 •

edited

nikosdouvlis commented Oct 12, 2023 •

edited

LekoArts Nov 6, 2023 •

edited