chore(clerk-js): Deprecate experimental captcha from Clerk singleton #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e7efefe The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikosdouvlis
approved these changes
Oct 17, 2023
Merged
dimkl
reviewed
Oct 18, 2023
| instanceType?: InstanceType; | ||
|
|
||
| /** Clerk flag for loading Clerk in a standard browser setup */ | ||
| isStandardBrowser?: boolean; |
There was a problem hiding this comment.
❓ isn't this getter always available? Shouldn't we use isStandardBrowser instead of isStandardBrowser??
dimkl
reviewed
Oct 18, 2023
| Controls the default state of the UserButton | ||
| */ | ||
| Controls the default state of the UserButton | ||
| */ |
There was a problem hiding this comment.
🙃
/**
* Controls the default state of the UserButton
*/
| Controls the default state of the OrganizationSwitcher | ||
| */ | ||
| Controls the default state of the OrganizationSwitcher | ||
| */ |
There was a problem hiding this comment.
🙃
/**
* Controls the default state of the OrganizationSwitcher
*/
| @@ -0,0 +1,22 @@ | |||
| import type Clerk from '../core/clerk'; | |||
| import createFapiClient from '../core/fapiClient'; | |||
There was a problem hiding this comment.
☁️ i'm kind of skeptic about having a dependency of core inside utils. It may result in a cyclic dependency in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the usage of the experimental captcha getter from Clerk singleton. We still need to retrieve this information for the feature to continue to work, so I have introduced a new util function
retrieveCaptchaInfoChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore