Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Types and NextJS 14 support (#1939, #1948) #1968

Merged
merged 2 commits into from Oct 31, 2023
Merged

fix: Types and NextJS 14 support (#1939, #1948) #1968

merged 2 commits into from Oct 31, 2023

Conversation

dimkl
Copy link
Member

@dimkl dimkl commented Oct 30, 2023 •
edited

Description

PRs synced:

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Oct 30, 2023
@dimkl dimkl requested a review from a team October 30, 2023 10:14
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023 •
edited

🦋 Changeset detected

Latest commit: 427122d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/backend Minor
@clerk/clerk-sdk-node Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LekoArts
Copy link
Member

You'll either need to drop the changesets files in this commit (but then things won't get released) or drop the CHANGELOG files. Otherwise the changelog of the v5 packages will have duplicate entries.

I'd drop the CHANGELOG files in this PR and let changesets create the release notes again

@dimkl
Copy link
Member Author

dimkl commented Oct 30, 2023

@LekoArts the current PR is not the process that should be followed in the future. It contains both the hotfixes code (that is not added to the main branch) and the changelog entries of the hotfix.
We need to have the changelog entries of the v4 hotfixes into the main CHANGELOG files. How would you do that?

@dimkl dimkl changed the title chore(repo): Sync v4 release of Version Packages #1936 chore(repo): Add v4 hotfixes from #1936 into main Oct 31, 2023
@LekoArts LekoArts changed the title chore(repo): Add v4 hotfixes from #1936 into main fix: Types and NextJS 14 support (#1939, #1948) Oct 31, 2023
@desiprisg @nikosdouvlis @dimkl
fix(backend): Support NextJS 14 (#1948)
427122d 
* fix(backend): Fix for next 14 fetch bind issue

* fix(nextjs): Use named imports for fetch runtime polyfill

Next14 seems to have changed the way it handles default exports when using the webpack bundler for some of their build variants when using `npm run dev`. This commit ensures that we no longer use the default export in an effort to improve compat between the different nextjs versions.

More information can be found here: https://esbuild.github.io/content-types/#default-interop
and here: #612

* Create late-dolphins-peel.md

---------

Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
@LekoArts LekoArts added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit a605335 Oct 31, 2023
7 checks passed
@LekoArts LekoArts deleted the release-v4-vp-1936 branch October 31, 2023 12:59
@clerk-cookie clerk-cookie mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees

@dimkl dimkl

Labels
backend sdk-node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dimkl @LekoArts @clerk-cookie @desiprisg