-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): Fix getToken()
from getAuth()
return value in v5
#2539
Conversation
馃 Changeset detectedLatest commit: 37fac81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fa82747
to
e2d6e6b
Compare
404043b
to
60ba984
Compare
!snapshot |
!snapshot |
Hey @dimkl - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/backend@1.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/chrome-extension@1.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/clerk-js@5.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/elements@0.0.3-snapshot.v60ba984 --save-exact
npm i @clerk/clerk-expo@1.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/fastify@1.0.1-snapshot.v60ba984 --save-exact
npm i gatsby-plugin-clerk@5.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/localizations@2.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/nextjs@5.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/clerk-react@5.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/remix@4.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/shared@2.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/themes@2.0.1-snapshot.v60ba984 --save-exact
npm i @clerk/types@4.0.1-snapshot.v60ba984 --save-exact |
2f08925
to
7ffbc66
Compare
7ffbc66
to
37fac81
Compare
We will proceed with this change in V6. |
Description
Change
SessionApi.getToken()
to return consistent{ data, errors }
return value and fix thegetToken()
from requestState to have the same return behavior as v4 (return Promise or throw error).This change fixes issues with
getToken()
in@clerk/nextjs
/@clerk/remix
/@clerk/fastify
/@clerk/sdk-node
/gatsby-plugin-clerk
:Example:
The change in
SessionApi.getToken()
return value is a breaking change, to keep the existing behavior use the following:Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/clerk-expo
@clerk/fastify
gatsby-plugin-clerk
@clerk/localizations
@clerk/nextjs
@clerk/clerk-react
@clerk/remix
@clerk/clerk-sdk-node
@clerk/shared
@clerk/themes
@clerk/types
build/tooling/chore