fix(clerk-react): Improve error message and checks for routing strategies #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 19d3f29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
force-pushed
the
sdk-1185-routing-stategy-priority
branch
from
a6f68f5
to
5caad02
Compare
dimkl
force-pushed
the
sdk-1185-routing-stategy-priority
branch
3 times, most recently
from
af310ca
to
79712e9
Compare
octoper
approved these changes
Jan 10, 2024
dimkl
force-pushed
the
sdk-1185-routing-stategy-priority
branch
from
79712e9
to
a82be4a
Compare
nikosdouvlis
approved these changes
Jan 11, 2024
dimkl
force-pushed
the
sdk-1185-routing-stategy-priority
branch
from
692df41
to
828dbad
Compare
dimkl
force-pushed
the
sdk-1185-routing-stategy-priority
branch
from
828dbad
to
4a64003
Compare
dimkl
force-pushed
the
sdk-1185-routing-stategy-priority
branch
from
4a64003
to
19d3f29
Compare
dimkl
added a commit
to clerk/clerk-docs
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply the following changes to components with routing props:
- default is
routing="path"andpathprop is required to be set via env or context- when
routing="hash"orrouting="virtual"is set the implicit (via env or context)pathoption is ignored- when
routing="hash"orrouting="virtual"thenpathprop is not allowed to be setExamples of components with routing props:
<CreateOrganization /><OrganizationProfile /><SignIn /><SignUp /><UserProfile />Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore