fix(clerk-js): Show custom pages errors when sdks are in dev mode #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: 2d5436c The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/backend@1.0.1-snapshot.v33c285b --save-exact
npm i @clerk/chrome-extension@1.0.1-snapshot.v33c285b --save-exact
npm i @clerk/clerk-js@5.0.1-snapshot.v33c285b --save-exact
npm i @clerk/clerk-expo@1.0.1-snapshot.v33c285b --save-exact
npm i @clerk/fastify@1.0.1-snapshot.v33c285b --save-exact
npm i gatsby-plugin-clerk@5.0.1-snapshot.v33c285b --save-exact
npm i @clerk/localizations@2.0.1-snapshot.v33c285b --save-exact
npm i @clerk/nextjs@5.0.1-snapshot.v33c285b --save-exact
npm i @clerk/clerk-react@5.0.1-snapshot.v33c285b --save-exact
npm i @clerk/remix@4.0.1-snapshot.v33c285b --save-exact
npm i @clerk/clerk-sdk-node@5.0.1-snapshot.v33c285b --save-exact
npm i @clerk/shared@2.0.1-snapshot.v33c285b --save-exact
npm i @clerk/themes@2.0.1-snapshot.v33c285b --save-exact
npm i @clerk/types@4.0.1-snapshot.v33c285b --save-exact |
panteliselef
changed the title
panteliselef
commented
Feb 15, 2024
packages/remix/src/ssr/utils.ts
Outdated
| @@ -123,6 +123,7 @@ export function getResponseClerkState(requestState: RequestState, context: AppLo | |||
| __clerkJSVersion: getEnvVariable('CLERK_JS_VERSION', context), | |||
| __telemetryDisabled: isTruthy(getEnvVariable('CLERK_TELEMETRY_DISABLED', context)), | |||
| __telemetryDebug: isTruthy(getEnvVariable('CLERK_TELEMETRY_DEBUG', context)), | |||
| __environment: getEnvVariable('NODE_ENV', context) || getEnvVariable('ENVIRONMENT', context), | |||
There was a problem hiding this comment.
For Remix we should recommend users to add the ENVIRONMENT env var in their configs.
panteliselef
requested review from
dimkl,
nikosdouvlis,
anagstef and
LekoArts
There is no default way to grab the env in remix, so we are skipping it for now.
panteliselef
force-pushed
the
elef/SDK-885
branch
from
bee7f58
to
2d5436c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Details
All of our SDKs consume the production version of
clerk-js, with this change we acquire more information about the environment each sdk runs on.For this case we want to log warning or errors that we wouldn't want to log if the app was used in it's final production version.
Video example
Screen.Recording.2024-02-15.at.3.17.10.PM.mov
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change