Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): Add support for Root Layout feature for v4 #2952

Closed
wants to merge 3 commits into from

Conversation

octoper
Copy link
Member

@octoper octoper commented Mar 7, 2024

Description

This PR addresses a couple problems for Remix:

  • Adds root Layout feature that was introduced in Remix v2.7
  • Fixes a Cloudflare Worker specific error, see the error reported to the Wrangler repo here
  • Updates @clerk/remix dependencies to the latest minor version

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 馃悰 Bug fix
  • 馃専 New feature
  • 馃敤 Breaking change
  • 馃摉 Refactoring / dependency upgrade / documentation
  • other:

@octoper octoper self-assigned this Mar 7, 2024
@octoper octoper requested a review from a team as a code owner March 7, 2024 16:21
@octoper octoper requested review from nikosdouvlis and removed request for a team March 7, 2024 16:21
Copy link

changeset-bot bot commented Mar 7, 2024

馃 Changeset detected

Latest commit: a25feba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/remix Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper requested a review from a team March 7, 2024 16:21
@octoper octoper requested a review from desiprisg March 7, 2024 16:22
@octoper
Copy link
Member Author

octoper commented Mar 7, 2024

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/remix 3.2.0-snapshot.vfdf2700

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/remix

npm i @clerk/remix@3.2.0-snapshot.vfdf2700 --save-exact

@octoper octoper marked this pull request as draft March 7, 2024 20:52
const error = useRouteError();

if (error) {
return ClerkErrorBoundary();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to check the type of error here?
What happens if a loader throws a user-defined error? I think this would trigger the interstitial for v4, isn't that the case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, yeah I want to test that to see what happens that's why I marked it as draft so I can test it tomorrow and apply a fix.

@octoper octoper closed this Mar 12, 2024
@octoper octoper deleted the vaggelis/sdk-1422-v4-backport branch March 12, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants