-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix): Add support for Root Layout feature for v4 #2952
Conversation
馃 Changeset detectedLatest commit: a25feba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!snapshot |
Hey @octoper - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/remix@3.2.0-snapshot.vfdf2700 --save-exact |
const error = useRouteError(); | ||
|
||
if (error) { | ||
return ClerkErrorBoundary(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to check the type of error here?
What happens if a loader throws a user-defined error? I think this would trigger the interstitial for v4, isn't that the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, yeah I want to test that to see what happens that's why I marked it as draft so I can test it tomorrow and apply a fix.
Description
This PR addresses a couple problems for Remix:
@clerk/remix
dependencies to the latest minor versionChecklist
npm test
runs as expected.npm run build
runs as expected.Type of change