feat(backend): Export the JSON types for clerk resources #2965
Conversation
馃 Changeset detectedLatest commit: 5bf1f61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Question for reviewers: Is there anything in JSON.ts that might not be beneficial to export? |
desiprisg
force-pushed
the
george/sdk-1489-export-the-json-types-from-clerkbackend
branch
from
fcaa0fd
to
740f810
Compare
|
Should these be re-exported from the rest of "server" packages ? next, fastify, etc. |
I think we re-export everything by default, but I'll check, |
|
@desiprisg we are not. Check this we are very explicit about which types we return. So far we are just returning the classes as types. We probably need to do the same for the JSON types. |
|
I would suggest we export explicitly only the types we want and avoid |
packages/backend/src/index.ts
Outdated
| /** | ||
| * JSON types | ||
| */ | ||
| export type * from './api/resources/JSON'; |
There was a problem hiding this comment.
馃敡 Let's export ONLY the types we want to and avoid * as it may result in unwanted exports in the future since the api/resources/JSON exports are considered to be consumed internally.
There was a problem hiding this comment.
@desiprisg PTAL at this one as we'd like to release today
There was a problem hiding this comment.
Done, PTAL and let me know if there's anything we want to avoid exporting for now.
desiprisg
force-pushed
the
george/sdk-1489-export-the-json-types-from-clerkbackend
branch
from
740f810
to
5bf1f61
Compare
nikosdouvlis
deleted the
george/sdk-1489-export-the-json-types-from-clerkbackend
branch
Description
Export the JSON types for clerk resources
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change