Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Added missing organizationId to UserCountParams for getUserList #3240

Merged
merged 4 commits into from Apr 23, 2024

Conversation

royanger
Copy link
Member

Description

Added missing parameter for getUserList

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Apr 23, 2024

🦋 Changeset detected

Latest commit: 3c5e626

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/backend Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to BAPI this is valid, so approving, thanks @royanger

Copy link
Member

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter organizationId is added in UserCountParams and not in the UserListParams. Based on our docs https://clerk.com/docs/reference/backend-api/tag/Users#operation/GetUsersCount the organization_id / organizationId is not supported by the User count endpoint.
I would suggest you add it only in the UserListParams or we should update our OpenAPI to indicate that it's available for both and then merge this PR.

@panteliselef
Copy link
Member

@dimkl seems that last_active_at_since is also used in UserCountParams and based on the link you sent it shouldn't be there

@dimkl
Copy link
Member

dimkl commented Apr 23, 2024

last_active_at_since

@panteliselef We probably need to move to UserListParams too.

@royanger
Copy link
Member Author

last_active_at_since

@panteliselef We probably need to move to UserListParams too.

Want me to add this to the PR here?

royanger added a commit that referenced this pull request Apr 23, 2024
royanger added a commit that referenced this pull request Apr 23, 2024
@royanger royanger force-pushed the roy/add-missing-params-to-getUserList branch from 588f7fb to 7410498 Compare April 23, 2024 18:43
@royanger royanger requested a review from dimkl April 23, 2024 18:43
@royanger royanger force-pushed the roy/add-missing-params-to-getUserList branch from 7410498 to 3c5e626 Compare April 23, 2024 20:57
@royanger royanger enabled auto-merge (squash) April 23, 2024 20:58
@royanger royanger merged commit 65503dc into main Apr 23, 2024
10 checks passed
@royanger royanger deleted the roy/add-missing-params-to-getUserList branch April 23, 2024 21:08
@clerk-cookie clerk-cookie mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants