New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): Added missing organizationId to UserCountParams for getUserList #3240
Conversation
🦋 Changeset detectedLatest commit: 3c5e626 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to BAPI this is valid, so approving, thanks @royanger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter organizationId
is added in UserCountParams
and not in the UserListParams
. Based on our docs https://clerk.com/docs/reference/backend-api/tag/Users#operation/GetUsersCount the organization_id
/ organizationId
is not supported by the User count endpoint.
I would suggest you add it only in the UserListParams
or we should update our OpenAPI to indicate that it's available for both and then merge this PR.
@dimkl seems that |
@panteliselef We probably need to move to |
Want me to add this to the PR here? |
588f7fb
to
7410498
Compare
7410498
to
3c5e626
Compare
Description
Added missing parameter for getUserList
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change