Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export webhook types #3248

Merged
merged 2 commits into from Apr 24, 2024
Merged

Export webhook types #3248

merged 2 commits into from Apr 24, 2024

Conversation

nikosdouvlis
Copy link
Member

@nikosdouvlis nikosdouvlis commented Apr 24, 2024

Description

  • Export webhook events and types from @clerk/backend
  • Export webhook events and types from @clerk/nextjs/server

As requested by multiple users, these types are useful when extracting webhook handler behavior into smaller functions, eg:

export handleUserUpdated(data: UserJSON) {}

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 馃悰 Bug fix
  • 馃専 New feature
  • 馃敤 Breaking change
  • 馃摉 Refactoring / dependency upgrade / documentation
  • other:

Closes SDK1678

Copy link

changeset-bot bot commented Apr 24, 2024

馃 Changeset detected

Latest commit: 3c545bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@clerk/backend Patch
@clerk/nextjs Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挴

@nikosdouvlis nikosdouvlis merged commit 3c6e5a6 into main Apr 24, 2024
10 checks passed
@nikosdouvlis nikosdouvlis deleted the nikos/export-webhook-types branch April 24, 2024 10:56
@clerk-cookie clerk-cookie mentioned this pull request Apr 24, 2024
@andrictham
Copy link

andrictham commented Apr 25, 2024

@nikosdouvlis As of 5.0.2, EmailAddressJSON isn鈥檛 exported from @clerk/nextjs/server. They used to be in 4.30.0.

I鈥檓 currently having to import it from @clerk/backend.

Could you re-export it in @clerk/nextjs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants