chore(localizations,themes): Drop react as peer dependency #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also drop `@type/nodes` as devDependency
馃 Changeset detectedLatest commit: c5f5467 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
approved these changes
Apr 26, 2024
.changeset/mean-snakes-appear.md
Outdated
| '@clerk/themes': minor | ||
| --- | ||
|
|
||
| Drop react as peer dependency from `@clerk/localizations` and `@clerk/themes`. |
There was a problem hiding this comment.
Suggested change
| Drop react as peer dependency from `@clerk/localizations` and `@clerk/themes`. | |
| Drop `react` and `react-dom` as peer dependencies since they are not necessary for this package |
Changesets will already put the context of where they are removed from into the changelog 馃憤
nikosdouvlis
approved these changes
Apr 26, 2024
panteliselef
deleted the
elef/sdk-1687-drop-react-as-peerdependency-for-localizations-and-themes
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@type/nodesas devDependencyChecklist
npm testruns as expected.npm run buildruns as expected.Type of change