Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared): Detection of legacy host in apiUrlFromPublishableKey #3333

Merged
merged 1 commit into from
May 7, 2024

Conversation

BRKalow
Copy link
Member

@BRKalow BRKalow commented May 7, 2024

Description

In Core 2, we have logic that determines the default Clerk API URL from the publishable key. This logic didn't account for the legacy FAPI URL scheme, and so they were being treated as "local". This PR updates the logic to account for the legacy keys, properly defaulting to the production Clerk API URL.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@BRKalow BRKalow requested a review from a team May 7, 2024 04:23
Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 06ca35d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@clerk/shared Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/elements Patch
@clerk/clerk-expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BRKalow BRKalow changed the title fix(shared): Fix detection of legacy publishable keys in apiUrlFromPublishableKey fix(shared): Fix detection of legacy host in apiUrlFromPublishableKey May 7, 2024
@LekoArts LekoArts changed the title fix(shared): Fix detection of legacy host in apiUrlFromPublishableKey fix(shared): Detection of legacy host in apiUrlFromPublishableKey May 7, 2024
@LekoArts LekoArts merged commit f5804a2 into main May 7, 2024
10 checks passed
@LekoArts LekoArts deleted the brk.fix/legacy-publishable-key-api-url branch May 7, 2024 08:48
@clerk-cookie clerk-cookie mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants