feat(clerk-react,shared): Add telemetry events for React hooks #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: e24fbfb The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LauraBeatris
force-pushed
the
telemetry-react-hooks
branch
2 times, most recently
from
86126eb
to
03dbfa5
Compare
LauraBeatris
commented
May 7, 2024
| @@ -24,6 +26,10 @@ export const useSignIn: UseSignIn = () => { | |||
| const isomorphicClerk = useIsomorphicClerkContext(); | |||
| const client = useClientContext(); | |||
|
|
|||
| useEffect(() => { | |||
| isomorphicClerk.telemetry?.record(eventMethodCalled('useSignIn')); | |||
There was a problem hiding this comment.
Hooks aren't necessary methods per se. However, I don't see the benefits of creating another event type for it, cause it wouldn't change much in terms of querying that data.
Anyway, open for feedback here!
LauraBeatris
requested review from
BRKalow,
LekoArts and
a team
and removed request for
BRKalow and
LekoArts
panteliselef
approved these changes
May 7, 2024
LauraBeatris
force-pushed
the
telemetry-react-hooks
branch
from
e41aaad
to
e24fbfb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves SDK-1672
Add telemetry events for
useSignIn,useSignUp,useOrganizationsanduseOrganizationList. This will allow us to track the usage of hooks for custom flows.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change