-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix): Ensure headers with the same name do not get overwritten #3345
Conversation
馃 Changeset detectedLatest commit: 7f0573b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!snapshot |
Hey @BRKalow - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/backend@1.1.2-snapshot.vaa3ad1f --save-exact
npm i @clerk/chrome-extension@1.0.6-snapshot.vaa3ad1f --save-exact
npm i @clerk/clerk-js@5.2.2-snapshot.vaa3ad1f --save-exact
npm i @clerk/elements@0.3.3-snapshot.vaa3ad1f --save-exact
npm i @clerk/eslint-config-custom@0.0.1-snapshot.vaa3ad1f --save-exact
npm i @clerk/clerk-expo@1.0.6-snapshot.vaa3ad1f --save-exact
npm i @clerk/express@0.0.5-snapshot.vaa3ad1f --save-exact
npm i @clerk/fastify@1.0.4-snapshot.vaa3ad1f --save-exact
npm i gatsby-plugin-clerk@5.0.0-beta.45 --save-exact
npm i @clerk/nextjs@5.0.7-snapshot.vaa3ad1f --save-exact
npm i @clerk/clerk-react@5.0.4-snapshot.vaa3ad1f --save-exact
npm i @clerk/remix@4.0.5-snapshot.vaa3ad1f --save-exact
npm i @clerk/clerk-sdk-node@5.0.4-snapshot.vaa3ad1f --save-exact
npm i @clerk/shared@2.0.2-snapshot.vaa3ad1f --save-exact
npm i @clerk/testing@1.0.3-snapshot.vaa3ad1f --save-exact
npm i @clerk/themes@2.1.3-snapshot.vaa3ad1f --save-exact
npm i @clerk/types@4.2.1-snapshot.vaa3ad1f --save-exact |
Description
When authenticating a request, it's possible we may pass multiple headers with the same name (e.g. multiple
Set-Cookie
headers). By usingheaders.set()
, we were only accepting the last header of that name. Switching toheaders.append()
should fix this.Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change